put unlock after lock

Bas van Kervel · Bas van Kervel · commit 652eea71febb · 2015-09-08T12:42:29.000+02:00
diff --git a/miner/agent.go b/miner/agent.go
@@ -61,10 +61,10 @@ func (self *CpuAgent) Stop() {
 }
 
 func (self *CpuAgent) Start() {
-	defer self.mu.Unlock()
 	self.mu.Lock()
-
-	if atomic.LoadInt32(&self.isMining) == 1 {
+	defer self.mu.Unlock()
+	
+	if !atomic.CompareAndSwapInt32(&self.isMining, 0, 1) {
 		return // agent already started
 	}
 
@@ -74,8 +74,6 @@ func (self *CpuAgent) Start() {
 	self.workCh = make(chan *Work, 1)
 
 	go self.update()
-
-	atomic.StoreInt32(&self.isMining, 1)
 }
 
 func (self *CpuAgent) update() {

Original file line number	Diff line number	Diff line change
`@@ -61,10 +61,10 @@ func (self *CpuAgent) Stop() {`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`func (self *CpuAgent) Start() {`
`64`		`- defer self.mu.Unlock()`
`65`	`64`	`self.mu.Lock()`
`66`		`-`
`67`		`- if atomic.LoadInt32(&self.isMining) == 1 {`
	`65`	`+ defer self.mu.Unlock()`
	`66`	`+`
	`67`	`+ if !atomic.CompareAndSwapInt32(&self.isMining, 0, 1) {`
`68`	`68`	`return // agent already started`
`69`	`69`	`}`
`70`	`70`
`@@ -74,8 +74,6 @@ func (self *CpuAgent) Start() {`
`74`	`74`	`self.workCh = make(chan *Work, 1)`
`75`	`75`
`76`	`76`	`go self.update()`
`77`		`-`
`78`		`- atomic.StoreInt32(&self.isMining, 1)`
`79`	`77`	`}`
`80`	`78`
`81`	`79`	`func (self *CpuAgent) update() {`