Skip to content

Commit 65e1095

Browse files
committed
consensus/ethash: close mmap before rename, windows limitation
1 parent ee05cc4 commit 65e1095

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

consensus/ethash/ethash.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,13 +130,16 @@ func memoryMapAndGenerate(path string, size uint64, generator func(buffer []uint
130130
data := buffer[len(dumpMagic):]
131131
generator(data)
132132

133-
if err := mem.Flush(); err != nil {
134-
mem.Unmap()
135-
dump.Close()
133+
if err := mem.Unmap(); err != nil {
134+
return nil, nil, nil, err
135+
}
136+
if err := dump.Close(); err != nil {
137+
return nil, nil, nil, err
138+
}
139+
if err := os.Rename(temp, path); err != nil {
136140
return nil, nil, nil, err
137141
}
138-
os.Rename(temp, path)
139-
return dump, mem, data, nil
142+
return memoryMap(path)
140143
}
141144

142145
// cache wraps an ethash cache with some metadata to allow easier concurrent use.

0 commit comments

Comments
 (0)