Skip to content

Commit 6fe0252

Browse files
authored
rpc, internal/cmdtest: increase timeout in tests (#27083)
This change gives the cmd-tests have a bit more time to finish before getting forcibly torn down.
1 parent 944e1a0 commit 6fe0252

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

cmd/geth/consolecmd_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ func TestAttachWelcome(t *testing.T) {
116116
waitForEndpoint(t, endpoint, 3*time.Second)
117117
testAttachWelcome(t, geth, endpoint, httpAPIs)
118118
})
119-
geth.ExpectExit()
119+
geth.Kill()
120120
}
121121

122122
func testAttachWelcome(t *testing.T, geth *testgeth, endpoint, apis string) {

internal/cmdtest/test_cmd.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ func (tt *TestCmd) Kill() {
237237
}
238238

239239
func (tt *TestCmd) withKillTimeout(fn func()) {
240-
timeout := time.AfterFunc(5*time.Second, func() {
240+
timeout := time.AfterFunc(30*time.Second, func() {
241241
tt.Log("killing the child process (timeout)")
242242
tt.Kill()
243243
})

rpc/client.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ var (
4343
const (
4444
// Timeouts
4545
defaultDialTimeout = 10 * time.Second // used if context has no deadline
46-
subscribeTimeout = 5 * time.Second // overall timeout eth_subscribe, rpc_modules calls
46+
subscribeTimeout = 10 * time.Second // overall timeout eth_subscribe, rpc_modules calls
4747
)
4848

4949
const (

0 commit comments

Comments
 (0)