Commit 8500134
cmd/evm: address PR feedback on blocktest stdin support
This commit addresses all feedback from @rjl493456442:
1. Result printing location: Removed duplicate report() call from
inside test loop. Now uses dedicated traceEndMarker on stderr
instead of printing full results mid-execution.
2. Fork assignment: Fork now always assigned regardless of tracer
or pass/fail status. Root only assigned when test succeeds,
following correct semantics.
3. Log suppression: Removed automatic log suppression. Users can
control logging via standard --verbosity and --log.file flags.
Only one rare INFO log exists in blocktest path.
The traceEndMarker provides clear delimiter for trace parsers
(e.g., goevmlab) without duplicating test results. Format:
{"testEnd":{"name":"...","pass":true,"fork":"...","root":"..."}}
This follows precedent from Nethermind PR #9432.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 838ef5c commit 8500134
1 file changed
+45
-10
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | 31 | | |
33 | 32 | | |
34 | 33 | | |
| |||
81 | 80 | | |
82 | 81 | | |
83 | 82 | | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
84 | 118 | | |
85 | 119 | | |
86 | 120 | | |
| |||
96 | 130 | | |
97 | 131 | | |
98 | 132 | | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | 133 | | |
105 | 134 | | |
106 | 135 | | |
| |||
128 | 157 | | |
129 | 158 | | |
130 | 159 | | |
131 | | - | |
132 | | - | |
133 | | - | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
134 | 164 | | |
135 | | - | |
136 | 165 | | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
137 | 172 | | |
138 | 173 | | |
139 | 174 | | |
| |||
0 commit comments