signer/core: fix reference issue in key derivation (#19827)

gballet · karalabe · commit 9466b9eec5d7 · 2019-07-18T15:17:32.000+03:00
* signer/core: fix reference issue in key derivation

* Review feedback
diff --git a/accounts/usbwallet/wallet.go b/accounts/usbwallet/wallet.go
@@ -479,7 +479,8 @@ func (w *wallet) Derive(path accounts.DerivationPath, pin bool) (accounts.Accoun
 
 	if _, ok := w.paths[address]; !ok {
 		w.accounts = append(w.accounts, account)
-		w.paths[address] = path
+		w.paths[address] = make(accounts.DerivationPath, len(path))
+		copy(w.paths[address], path)
 	}
 	return account, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -479,7 +479,8 @@ func (w *wallet) Derive(path accounts.DerivationPath, pin bool) (accounts.Accoun`
`479`	`479`
`480`	`480`	`if _, ok := w.paths[address]; !ok {`
`481`	`481`	`w.accounts = append(w.accounts, account)`
`482`		`- w.paths[address] = path`
	`482`	`+ w.paths[address] = make(accounts.DerivationPath, len(path))`
	`483`	`+ copy(w.paths[address], path)`
`483`	`484`	`}`
`484`	`485`	`return account, nil`
`485`	`486`	`}`