Skip to content

Commit 997cb2e

Browse files
committed
use gauge to replace meter
Signed-off-by: jsvisa <[email protected]>
1 parent 87d1a9c commit 997cb2e

File tree

2 files changed

+18
-22
lines changed

2 files changed

+18
-22
lines changed

core/state/metrics.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,14 @@ var (
2929
storageTriesUpdatedMeter = metrics.NewRegisteredMeter("state/update/storagenodes", nil)
3030
accountTrieDeletedMeter = metrics.NewRegisteredMeter("state/delete/accountnodes", nil)
3131
storageTriesDeletedMeter = metrics.NewRegisteredMeter("state/delete/storagenodes", nil)
32+
33+
// State size metrics
34+
accountCountGauge = metrics.NewRegisteredGauge("state/account/count", nil)
35+
accountBytesGauge = metrics.NewRegisteredGauge("state/account/bytes", nil)
36+
storageCountGauge = metrics.NewRegisteredGauge("state/storage/count", nil)
37+
storageBytesGauge = metrics.NewRegisteredGauge("state/storage/bytes", nil)
38+
trienodeCountGauge = metrics.NewRegisteredGauge("state/trienode/count", nil)
39+
trienodeBytesGauge = metrics.NewRegisteredGauge("state/trienode/bytes", nil)
40+
contractCountGauge = metrics.NewRegisteredGauge("state/contract/count", nil)
41+
contractBytesGauge = metrics.NewRegisteredGauge("state/contract/bytes", nil)
3242
)

core/state/statesize.go

Lines changed: 8 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -26,25 +26,11 @@ import (
2626
"github.com/ethereum/go-ethereum/crypto"
2727
"github.com/ethereum/go-ethereum/ethdb"
2828
"github.com/ethereum/go-ethereum/log"
29-
"github.com/ethereum/go-ethereum/metrics"
3029
"github.com/ethereum/go-ethereum/rlp"
3130
"github.com/ethereum/go-ethereum/triedb"
3231
"golang.org/x/sync/errgroup"
3332
)
3433

35-
// State size metrics
36-
var (
37-
// Baseline state size metrics
38-
stateSizeAccountsCountMeter = metrics.NewRegisteredMeter("statedb/statesize/accounts/count", nil)
39-
stateSizeAccountsBytesMeter = metrics.NewRegisteredMeter("statedb/statesize/accounts/bytes", nil)
40-
stateSizeStorageCountMeter = metrics.NewRegisteredMeter("statedb/statesize/storage/count", nil)
41-
stateSizeStorageBytesMeter = metrics.NewRegisteredMeter("statedb/statesize/storage/bytes", nil)
42-
stateSizeTrieNodesCountMeter = metrics.NewRegisteredMeter("statedb/statesize/trienodes/count", nil)
43-
stateSizeTrieNodesBytesMeter = metrics.NewRegisteredMeter("statedb/statesize/trienodes/bytes", nil)
44-
stateSizeContractsCountMeter = metrics.NewRegisteredMeter("statedb/statesize/contracts/count", nil)
45-
stateSizeContractsBytesMeter = metrics.NewRegisteredMeter("statedb/statesize/contracts/bytes", nil)
46-
)
47-
4834
// StateSizeMetrics represents the current state size statistics
4935
type StateSizeMetrics struct {
5036
Root common.Hash // Root hash of the state trie
@@ -494,14 +480,14 @@ func (g *StateSizeGenerator) iterateTable(ctx context.Context, prefix []byte, na
494480
}
495481

496482
func (g *StateSizeGenerator) updateMetrics() {
497-
stateSizeAccountsCountMeter.Mark(int64(g.metrics.AccountCount))
498-
stateSizeAccountsBytesMeter.Mark(int64(g.metrics.AccountBytes))
499-
stateSizeStorageCountMeter.Mark(int64(g.metrics.StorageCount))
500-
stateSizeStorageBytesMeter.Mark(int64(g.metrics.StorageBytes))
501-
stateSizeTrieNodesCountMeter.Mark(int64(g.metrics.TrieNodeCount))
502-
stateSizeTrieNodesBytesMeter.Mark(int64(g.metrics.TrieNodeBytes))
503-
stateSizeContractsCountMeter.Mark(int64(g.metrics.ContractCount))
504-
stateSizeContractsBytesMeter.Mark(int64(g.metrics.ContractBytes))
483+
accountCountGauge.Update(int64(g.metrics.AccountCount))
484+
accountBytesGauge.Update(int64(g.metrics.AccountBytes))
485+
storageCountGauge.Update(int64(g.metrics.StorageCount))
486+
storageBytesGauge.Update(int64(g.metrics.StorageBytes))
487+
trienodeCountGauge.Update(int64(g.metrics.TrieNodeCount))
488+
trienodeBytesGauge.Update(int64(g.metrics.TrieNodeBytes))
489+
contractCountGauge.Update(int64(g.metrics.ContractCount))
490+
contractBytesGauge.Update(int64(g.metrics.ContractBytes))
505491
}
506492

507493
// persistMetrics saves the current metrics to the database

0 commit comments

Comments
 (0)