accounts/abi: avoid unnecessary alloc (#24128)

fomotrader · web-flow · commit 99be62a9b16f · 2021-12-20T10:25:46.000+01:00
diff --git a/accounts/abi/unpack.go b/accounts/abi/unpack.go
@@ -290,7 +290,7 @@ func tuplePointsTo(index int, output []byte) (start int, err error) {
 	offset := big.NewInt(0).SetBytes(output[index : index+32])
 	outputLen := big.NewInt(int64(len(output)))
 
-	if offset.Cmp(big.NewInt(int64(len(output)))) > 0 {
+	if offset.Cmp(outputLen) > 0 {
 		return 0, fmt.Errorf("abi: cannot marshal in to go slice: offset %v would go over slice boundary (len=%v)", offset, outputLen)
 	}
 	if offset.BitLen() > 63 {

Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,7 @@ func tuplePointsTo(index int, output []byte) (start int, err error) {`
`290`	`290`	`offset := big.NewInt(0).SetBytes(output[index : index+32])`
`291`	`291`	`outputLen := big.NewInt(int64(len(output)))`
`292`	`292`
`293`		`- if offset.Cmp(big.NewInt(int64(len(output)))) > 0 {`
	`293`	`+ if offset.Cmp(outputLen) > 0 {`
`294`	`294`	`return 0, fmt.Errorf("abi: cannot marshal in to go slice: offset %v would go over slice boundary (len=%v)", offset, outputLen)`
`295`	`295`	`}`
`296`	`296`	`if offset.BitLen() > 63 {`