eth: don't refetch non fitting blocks to avoid duplicates

karalabe · karalabe · commit aa250e228a7f · 2015-06-15T15:18:31.000+03:00
diff --git a/eth/sync.go b/eth/sync.go
@@ -214,7 +214,7 @@ func (pm *ProtocolManager) fetcher() {
 				if announce := pending[hash]; announce != nil {
 					// Drop the block if it surely cannot fit
 					if pm.chainman.HasBlock(hash) || !pm.chainman.HasBlock(block.ParentHash()) {
-						delete(pending, hash)
+						// delete(pending, hash) // if we drop, it will re-fetch it, wait for timeout?
 						continue
 					}
 					// Otherwise accumulate for import

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,7 @@ func (pm *ProtocolManager) fetcher() {`
`214`	`214`	`if announce := pending[hash]; announce != nil {`
`215`	`215`	`// Drop the block if it surely cannot fit`
`216`	`216`	`if pm.chainman.HasBlock(hash) \|\| !pm.chainman.HasBlock(block.ParentHash()) {`
`217`		`- delete(pending, hash)`
	`217`	`+ // delete(pending, hash) // if we drop, it will re-fetch it, wait for timeout?`
`218`	`218`	`continue`
`219`	`219`	`}`
`220`	`220`	`// Otherwise accumulate for import`