metrics: fix file descriptor leak when reading disk stats on linux

fjl · fjl · commit bf48ed32dd8b · 2015-08-03T16:27:36.000+02:00
The disk stats file was not closed after reading.
diff --git a/metrics/disk_linux.go b/metrics/disk_linux.go
@@ -34,6 +34,7 @@ func ReadDiskStats(stats *DiskStats) error {
 	if err != nil {
 		return err
 	}
+	defer inf.Close()
 	in := bufio.NewReader(inf)
 
 	// Iterate over the IO counter, and extract what we need

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@ func ReadDiskStats(stats *DiskStats) error {`
`34`	`34`	`if err != nil {`
`35`	`35`	`return err`
`36`	`36`	`}`
	`37`	`+ defer inf.Close()`
`37`	`38`	`in := bufio.NewReader(inf)`
`38`	`39`
`39`	`40`	`// Iterate over the IO counter, and extract what we need`