p2p/nat: delete port mapping before adding (#15222)

dherbst · fjl · commit d54e3539d453 · 2017-10-06T13:39:47.000+02:00
Fixes #1024
diff --git a/p2p/nat/natupnp.go b/p2p/nat/natupnp.go
@@ -62,6 +62,7 @@ func (n *upnp) AddMapping(protocol string, extport, intport int, desc string, li
 	}
 	protocol = strings.ToUpper(protocol)
 	lifetimeS := uint32(lifetime / time.Second)
+	n.DeleteMapping(protocol, extport, intport)
 	return n.client.AddPortMapping("", uint16(extport), protocol, uint16(intport), ip.String(), true, desc, lifetimeS)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,7 @@ func (n *upnp) AddMapping(protocol string, extport, intport int, desc string, li`
`62`	`62`	`}`
`63`	`63`	`protocol = strings.ToUpper(protocol)`
`64`	`64`	`lifetimeS := uint32(lifetime / time.Second)`
	`65`	`+ n.DeleteMapping(protocol, extport, intport)`
`65`	`66`	`return n.client.AddPortMapping("", uint16(extport), protocol, uint16(intport), ip.String(), true, desc, lifetimeS)`
`66`	`67`	`}`
`67`	`68`