core/rawdb: simplify HasCanonicalTransaction

cskiraly · cskiraly · commit d9db1d6b0123 · 2025-11-30T00:29:55.000+01:00
Signed-off-by: Csaba Kiraly &lt;csaba.kiraly@gmail.com&gt;
diff --git a/core/rawdb/accessors_indexes.go b/core/rawdb/accessors_indexes.go
@@ -176,8 +176,7 @@ func findTxInBlockBody(blockbody rlp.RawValue, target common.Hash) (*types.Trans
 
 // HasCanonicalTransaction checks whether a specific transaction is in the database.
 func HasCanonicalTransaction(db ethdb.Reader, hash common.Hash) bool {
-	blockNumber := ReadTxLookupEntry(db, hash)
-	return blockNumber != nil
+	return ReadTxLookupEntry(db, hash) != nil
 }
 
 // ReadCanonicalTransaction retrieves a specific transaction from the database, along

Original file line number	Diff line number	Diff line change
`@@ -176,8 +176,7 @@ func findTxInBlockBody(blockbody rlp.RawValue, target common.Hash) (*types.Trans`
`176`	`176`
`177`	`177`	`// HasCanonicalTransaction checks whether a specific transaction is in the database.`
`178`	`178`	`func HasCanonicalTransaction(db ethdb.Reader, hash common.Hash) bool {`
`179`		`- blockNumber := ReadTxLookupEntry(db, hash)`
`180`		`- return blockNumber != nil`
	`179`	`+ return ReadTxLookupEntry(db, hash) != nil`
`181`	`180`	`}`
`182`	`181`
`183`	`182`	`// ReadCanonicalTransaction retrieves a specific transaction from the database, along`