core: handle ignored error (#16065)

ferhatelmas · karalabe · commit dc7ca52b3b7c · 2018-02-14T22:02:51.000+02:00
- according to implementation of `IntrinsicGas`
we can continue execution since problem will be detected
later. However, early return is future-proof for changes.
diff --git a/core/state_transition.go b/core/state_transition.go
@@ -215,6 +215,9 @@ func (st *StateTransition) TransitionDb() (ret []byte, usedGas uint64, failed bo
 
 	// Pay intrinsic gas
 	gas, err := IntrinsicGas(st.data, contractCreation, homestead)
+	if err != nil {
+		return nil, 0, false, err
+	}
 	if err = st.useGas(gas); err != nil {
 		return nil, 0, false, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -215,6 +215,9 @@ func (st *StateTransition) TransitionDb() (ret []byte, usedGas uint64, failed bo`
`215`	`215`
`216`	`216`	`// Pay intrinsic gas`
`217`	`217`	`gas, err := IntrinsicGas(st.data, contractCreation, homestead)`
	`218`	`+ if err != nil {`
	`219`	`+ return nil, 0, false, err`
	`220`	`+ }`
`218`	`221`	`if err = st.useGas(gas); err != nil {`
`219`	`222`	`return nil, 0, false, err`
`220`	`223`	`}`