Skip to content

Commit de6a113

Browse files
eth/catalyst: only apply block if we actually have the state (#24598)
* eth/catalyst: only apply block if we actually have the state * add header to payload queue * Update cmd/geth/dbcmd.go Co-authored-by: Martin Holst Swende <[email protected]> Co-authored-by: Martin Holst Swende <[email protected]>
1 parent b502b6a commit de6a113

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

cmd/geth/dbcmd.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -747,6 +747,9 @@ func showMetaData(ctx *cli.Context) error {
747747
data = append(data, []string{"headBlock.Root", fmt.Sprintf("%v", b.Root())})
748748
data = append(data, []string{"headBlock.Number", fmt.Sprintf("%d (0x%x)", b.Number(), b.Number())})
749749
}
750+
if b := rawdb.ReadSkeletonSyncStatus(db); b != nil {
751+
data = append(data, []string{"SkeletonSyncStatus", string(b)})
752+
}
750753
if h := rawdb.ReadHeadHeader(db); h != nil {
751754
data = append(data, []string{"headHeader.Hash", fmt.Sprintf("%v", h.Hash())})
752755
data = append(data, []string{"headHeader.Root", fmt.Sprintf("%v", h.Root)})

eth/catalyst/api.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,11 @@ func (api *ConsensusAPI) NewPayloadV1(params beacon.ExecutableDataV1) (beacon.Pa
298298
log.Warn("Invalid timestamp", "parent", block.Time(), "block", block.Time())
299299
return api.invalid(errors.New("invalid timestamp")), nil
300300
}
301+
if !api.eth.BlockChain().HasBlockAndState(block.ParentHash(), block.NumberU64()-1) {
302+
api.remoteBlocks.put(block.Hash(), block.Header())
303+
log.Warn("State not available, ignoring new payload")
304+
return beacon.PayloadStatusV1{Status: beacon.ACCEPTED}, nil
305+
}
301306
log.Trace("Inserting block without sethead", "hash", block.Hash(), "number", block.Number)
302307
if err := api.eth.BlockChain().InsertBlockWithoutSetHead(block); err != nil {
303308
log.Warn("NewPayloadV1: inserting block failed", "error", err)

0 commit comments

Comments
 (0)