Skip to content

Commit df53e28

Browse files
committed
core: remove accountHashWait
1 parent 97b516b commit df53e28

File tree

3 files changed

+13
-17
lines changed

3 files changed

+13
-17
lines changed

core/blockchain.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2158,7 +2158,6 @@ func (bc *BlockChain) ProcessBlock(parentRoot common.Hash, block *types.Block, s
21582158
stats.AccountReads = statedb.AccountReads // Account reads are complete(in processing)
21592159
stats.StorageReads = statedb.StorageReads // Storage reads are complete(in processing)
21602160
stats.AccountUpdates = statedb.AccountUpdates // Account updates are complete(in validation)
2161-
stats.AccountUpdateWait = statedb.AccountUpdateWait
21622161
stats.StorageUpdates = statedb.StorageUpdates // Storage updates are complete(in validation)
21632162
stats.AccountHashes = statedb.AccountHashes // Account hashes are complete(in validation)
21642163

core/blockchain_stats.go

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,13 @@ import (
3030
// ExecuteStats includes all the statistics of a block execution in details.
3131
type ExecuteStats struct {
3232
// State read times
33-
AccountReads time.Duration // Time spent on the account reads
34-
StorageReads time.Duration // Time spent on the storage reads
35-
AccountHashes time.Duration // Time spent on the account trie hash
36-
AccountUpdates time.Duration // Time spent on the account trie update
37-
AccountUpdateWait time.Duration // Time spent on waiting the account trie from prefetching
38-
AccountCommits time.Duration // Time spent on the account trie commit
39-
StorageUpdates time.Duration // Time spent on the storage trie update
40-
StorageCommits time.Duration // Time spent on the storage trie commit
33+
AccountReads time.Duration // Time spent on the account reads
34+
StorageReads time.Duration // Time spent on the storage reads
35+
AccountHashes time.Duration // Time spent on the account trie hash
36+
AccountUpdates time.Duration // Time spent on the account trie update
37+
AccountCommits time.Duration // Time spent on the account trie commit
38+
StorageUpdates time.Duration // Time spent on the storage trie update
39+
StorageCommits time.Duration // Time spent on the storage trie commit
4140

4241
AccountLoaded int // Number of accounts loaded
4342
AccountUpdated int // Number of accounts updated
@@ -115,7 +114,7 @@ EVM execution: %v
115114
Validation: %v
116115
Account read: %v(%d)
117116
Storage read: %v(%d)
118-
Account hash: %v(wait=%v)
117+
Account hash: %v
119118
Storage hash: %v
120119
DB commit: %v
121120
Block write: %v
@@ -127,7 +126,7 @@ Total: %v
127126
common.PrettyDuration(s.Execution), common.PrettyDuration(s.Validation+s.CrossValidation),
128127
common.PrettyDuration(s.AccountReads), s.AccountLoaded,
129128
common.PrettyDuration(s.StorageReads), s.StorageLoaded,
130-
common.PrettyDuration(s.AccountHashes+s.AccountCommits+s.AccountUpdates), common.PrettyDuration(s.AccountUpdateWait),
129+
common.PrettyDuration(s.AccountHashes+s.AccountCommits+s.AccountUpdates),
131130
common.PrettyDuration(s.StorageCommits+s.StorageUpdates),
132131
common.PrettyDuration(s.TrieDBCommit+s.SnapshotCommit), common.PrettyDuration(s.BlockWrite),
133132
common.PrettyDuration(s.TotalTime), s.StateReadCacheStats)

core/state/statedb.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -140,11 +140,10 @@ type StateDB struct {
140140
witnessStats *stateless.WitnessStats
141141

142142
// Measurements gathered during execution for debugging purposes
143-
AccountReads time.Duration
144-
AccountHashes time.Duration
145-
AccountUpdates time.Duration
146-
AccountCommits time.Duration
147-
AccountUpdateWait time.Duration
143+
AccountReads time.Duration
144+
AccountHashes time.Duration
145+
AccountUpdates time.Duration
146+
AccountCommits time.Duration
148147

149148
StorageReads time.Duration
150149
StorageUpdates time.Duration
@@ -917,7 +916,6 @@ func (s *StateDB) IntermediateRoot(deleteEmptyObjects bool) common.Hash {
917916
} else {
918917
s.trie = trie
919918
}
920-
s.AccountUpdateWait += time.Since(start)
921919
}
922920
// Perform updates before deletions. This prevents resolution of unnecessary trie nodes
923921
// in circumstances similar to the following:

0 commit comments

Comments
 (0)