ethdb/memorydb: allow noop compact on memdb (#19907)

karalabe · web-flow · commit e46a01d56c19 · 2019-08-01T11:00:56.000+03:00
* ethdb/memorydb: allow noop compact on memdb

* ethdb/memorydb: fix comment type
diff --git a/ethdb/memorydb/memorydb.go b/ethdb/memorydb/memorydb.go
@@ -197,9 +197,10 @@ func (db *Database) Stat(property string) (string, error) {
 	return "", errors.New("unknown property")
 }
 
-// Compact is not supported on a memory database.
+// Compact is not supported on a memory database, but there's no need either as
+// a memory database doesn't waste space anyway.
 func (db *Database) Compact(start []byte, limit []byte) error {
-	return errors.New("unsupported operation")
+	return nil
 }
 
 // Len returns the number of entries currently present in the memory database.

Original file line number	Diff line number	Diff line change
`@@ -197,9 +197,10 @@ func (db *Database) Stat(property string) (string, error) {`
`197`	`197`	`return "", errors.New("unknown property")`
`198`	`198`	`}`
`199`	`199`
`200`		`-// Compact is not supported on a memory database.`
	`200`	`+// Compact is not supported on a memory database, but there's no need either as`
	`201`	`+// a memory database doesn't waste space anyway.`
`201`	`202`	`func (db *Database) Compact(start []byte, limit []byte) error {`
`202`		`- return errors.New("unsupported operation")`
	`203`	`+ return nil`
`203`	`204`	`}`
`204`	`205`
`205`	`206`	`// Len returns the number of entries currently present in the memory database.`