accounts/abi/abigen: simplify calculation whether or not a method's outputs should be gathered into a struct

jwasinger · jwasinger · commit e97cef6365b5 · 2025-02-17T17:39:03.000-08:00
diff --git a/accounts/abi/abigen/bindv2.go b/accounts/abi/abigen/bindv2.go
@@ -175,8 +175,8 @@ func (cb *contractBinder) bindMethod(original abi.Method) error {
 			cb.binder.BindStructType(output.Type)
 		}
 	}
-	isStructured := structured(original.Outputs)
 
+	var isStructured bool
 	// If the call returns multiple values, gather them into a struct
 	if len(normalized.Outputs) > 1 {
 		isStructured = true

Original file line number	Diff line number	Diff line change
`@@ -175,8 +175,8 @@ func (cb *contractBinder) bindMethod(original abi.Method) error {`
`175`	`175`	`cb.binder.BindStructType(output.Type)`
`176`	`176`	`}`
`177`	`177`	`}`
`178`		`- isStructured := structured(original.Outputs)`
`179`	`178`
	`179`	`+ var isStructured bool`
`180`	`180`	`// If the call returns multiple values, gather them into a struct`
`181`	`181`	`if len(normalized.Outputs) > 1 {`
`182`	`182`	`isStructured = true`