Skip to content

Commit efe1237

Browse files
authored
Revert "build: switch PPA from Gophers dep to manual download" (#20061)
1 parent 8eb646a commit efe1237

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

build/ci-notes.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,19 @@ variables `PPA_SIGNING_KEY` and `PPA_SSH_KEY` on Travis.
2222

2323
We want to build go-ethereum with the most recent version of Go, irrespective of the Go
2424
version that is available in the main Ubuntu repository. In order to make this possible,
25-
our PPA always fetches a recent Go release for the upstream server and uses that.
25+
our PPA depends on the ~gophers/ubuntu/archive PPA. Our source package build-depends on
26+
golang-1.11, which is co-installable alongside the regular golang package. PPA dependencies
27+
can be edited at https://launchpad.net/%7Eethereum/+archive/ubuntu/ethereum/+edit-dependencies
2628

2729
## Building Packages Locally (for testing)
2830

2931
You need to run Ubuntu to do test packaging.
3032

31-
Install Go and the Debian packaging tools:
33+
Add the gophers PPA and install Go 1.11 and Debian packaging tools:
3234

35+
$ sudo apt-add-repository ppa:gophers/ubuntu/archive
3336
$ sudo apt-get update
34-
$ sudo apt-get install build-essential golang devscripts debhelper python-bzrlib python-paramiko
37+
$ sudo apt-get install build-essential golang-1.11 devscripts debhelper python-bzrlib python-paramiko
3538

3639
Create the source packages:
3740

build/deb/ethereum/deb.control

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Source: {{.Name}}
22
Section: science
33
Priority: extra
44
Maintainer: {{.Author}}
5-
Build-Depends: debhelper (>= 8.0.0), golang
5+
Build-Depends: debhelper (>= 8.0.0), golang-1.11
66
Standards-Version: 3.9.5
77
Homepage: https://ethereum.org
88
Vcs-Git: git://github.com/ethereum/go-ethereum.git

build/deb/ethereum/deb.rules

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,11 @@
44
# Uncomment this to turn on verbose mode.
55
#export DH_VERBOSE=1
66

7-
# Launchpad rejects Go's access to $HOME, use custom folder
8-
export HOME=/tmp/home
7+
# Launchpad rejects Go's access to $HOME/.cache, use custom folder
8+
export GOCACHE=/tmp/go-build
99

1010
override_dh_auto_build:
11-
go get golang.org/dl/go1.13 && $HOME/go/bin/go1.13 download
12-
build/env.sh $HOME/go/bin/go1.13 run build/ci.go install -git-commit={{.Env.Commit}} -git-branch={{.Env.Branch}} -git-tag={{.Env.Tag}} -buildnum={{.Env.Buildnum}} -pull-request={{.Env.IsPullRequest}}
11+
build/env.sh /usr/lib/go-1.11/bin/go run build/ci.go install -git-commit={{.Env.Commit}} -git-branch={{.Env.Branch}} -git-tag={{.Env.Tag}} -buildnum={{.Env.Buildnum}} -pull-request={{.Env.IsPullRequest}}
1312

1413
override_dh_auto_test:
1514

0 commit comments

Comments
 (0)