internal/ethapi: avoid int overflow in GetTransactionReceipt (#26911)

Darioush Jalali · web-flow · commit f73365738309 · 2023-03-16T23:53:39.000+01:00
diff --git a/internal/ethapi/api.go b/internal/ethapi/api.go
@@ -1626,7 +1626,7 @@ func (s *TransactionAPI) GetTransactionReceipt(ctx context.Context, hash common.
 	if err != nil {
 		return nil, err
 	}
-	if len(receipts) <= int(index) {
+	if uint64(len(receipts)) <= index {
 		return nil, nil
 	}
 	receipt := receipts[index]

Original file line number	Diff line number	Diff line change
`@@ -1626,7 +1626,7 @@ func (s *TransactionAPI) GetTransactionReceipt(ctx context.Context, hash common.`
`1626`	`1626`	`if err != nil {`
`1627`	`1627`	`return nil, err`
`1628`	`1628`	`}`
`1629`		`- if len(receipts) <= int(index) {`
	`1629`	`+ if uint64(len(receipts)) <= index {`
`1630`	`1630`	`return nil, nil`
`1631`	`1631`	`}`
`1632`	`1632`	`receipt := receipts[index]`