core/rawdb: correct misleading comments for state history accessors #32783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update comments in core/rawdb/accessors_state.go for:
These functions do not return a “state root”. They return the account/storage index blobs and concatenated account/storage data blobs from the ancient store. The new comments align with the documented layout in triedb/pathdb/history_state.go (metadata, account index, account data, storage index, storage data) and with how the readers consume these blobs. This prevents developer confusion and misinterpretation of the APIs while preserving the clarification about id-1 freezer positioning. No functional code changes.