Skip to content

Add MaxUsedGas field to eth_simulateV1 response #32789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add MaxUsedGas field to eth_simulateV1 response #32789

wants to merge 1 commit into from

Conversation

Rhovian
Copy link

@Rhovian Rhovian commented Sep 29, 2025

closes #32741

@Rhovian
Copy link
Author

Rhovian commented Sep 30, 2025

@s1na I see @rjl493456442 assigned you to this, lmk if you'd like any changes or if I should just close, thanks

@s1na
Copy link
Contributor

s1na commented Oct 1, 2025

There are 2 points about this PR:

  • We first need to agree with other clients whether to add this field.
  • The implementation: the applyMessage result already contains the maxUsedGas field. You can use that.

@Rhovian
Copy link
Author

Rhovian commented Oct 1, 2025

There are 2 points about this PR:

  • We first need to agree with other clients whether to add this field.
  • The implementation: the applyMessage result already contains the maxUsedGas field. You can use that.

ah, I didn't realize this required coordination with other clients, I can also implement in reth.

will fix the implemntation issue, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl Awaiting requested review from fjl fjl is a code owner

@s1na s1na Awaiting requested review from s1na s1na is a code owner

@lightclient lightclient Awaiting requested review from lightclient lightclient is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@s1na s1na

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MaxUsedGas field to eth_simulateV1 response
2 participants
@Rhovian @s1na