Skip to content

Fix eth/filters: Unsubscription Missing at filter Api With Subscrip… #32794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix eth/filters: Unsubscription Missing at filter Api With Subscrip… #32794

wants to merge 1 commit into from

Conversation

CertiK-Geth
Copy link
Contributor

#32793
Fix issue #32793

@MariusVanDerWijden
Copy link
Member

MariusVanDerWijden commented Oct 1, 2025 •
edited
Loading

I guess its fine, the user might unsubscribe themselves, but afaict unsubscribing twice does not error.
Ah since we remove the subscription, the user does not have the option to unsubscribe themselves?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CertiK-Geth @MariusVanDerWijden