Skip to content

core/vm: don't call SetCode after contract creation if initcode didn't return anything #32916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2025
Merged

core/vm: don't call SetCode after contract creation if initcode didn't return anything #32916

merged 1 commit into from
Oct 20, 2025
+3 −1

Conversation

jwasinger
Copy link
Contributor

@jwasinger jwasinger commented Oct 15, 2025 •
edited
Loading

The code change is a noop here, and the tracing hook shouldn't be invoked if the account code doesn't actually change.

@jwasinger jwasinger changed the title core/vm: don't call SetCode on target of contract creation if initcode didn't return anything core/vm: don't call SetCode after contract creation if initcode didn't return anything Oct 15, 2025
@jwasinger
Copy link
Contributor Author

Sorry, meant to ask for review @s1na and somehow I assigned you instead.

@jwasinger jwasinger requested a review from s1na October 15, 2025 09:36
@s1na
Copy link
Contributor

s1na commented Oct 15, 2025

should be fixed via #32915 (comment) too

@jwasinger jwasinger mentioned this pull request Oct 20, 2025
Open
gballet
gballet approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked that it doesn't impact further stateless work, and while I'm wondering if this might not make debugging more annoying later, I think it's pretty safe to merge... and not have tracers be confused when there is a "no-op" update.

@gballet gballet added this to the 1.16.6 milestone Oct 20, 2025
@gballet gballet merged commit b6a4ac9 into ethereum:master Oct 20, 2025
7 of 8 checks passed
@jwasinger jwasinger deleted the noop-code-change-empty-initcode branch October 20, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gballet gballet gballet approved these changes

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

@s1na s1na Awaiting requested review from s1na

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.16.6

Development

Successfully merging this pull request may close these issues.

3 participants

@jwasinger @s1na @gballet