Skip to content

core: use legacy chain freezer only if dir is non-empty #33032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2025
Merged

core: use legacy chain freezer only if dir is non-empty #33032

merged 2 commits into from
Oct 28, 2025

Conversation

@jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Oct 27, 2025 •
edited
Loading

When I'm running geth with --datadir.ancient=xxx and xxx is an empty directory, geth will always use the legacy freezer dir struct:

mkdir -p /tmp/{geth,ancient}

./build/bin/geth --datadir /tmp/geth --datadir.ancient /tmp/ancient

Then the directory of /tmp/ancient is:

$ ll /tmp/ancient/
total 64
drwxr-xr-x@ 16 jsvisa  wheel   512 Oct 27 23:57 ./
drwxrwxrwt  41 root    wheel  1312 Oct 27 23:57 ../
-rw-r--r--@  1 jsvisa  wheel     0 Oct 27 23:57 bodies.0000.cdat
-rw-r--r--@  1 jsvisa  wheel     6 Oct 27 23:57 bodies.cidx
-rw-r--r--@  1 jsvisa  wheel     4 Oct 27 23:57 bodies.meta
-rw-------@  1 jsvisa  wheel     0 Oct 27 23:57 FLOCK
-rw-r--r--@  1 jsvisa  wheel     0 Oct 27 23:57 hashes.0000.rdat
-rw-r--r--@  1 jsvisa  wheel     4 Oct 27 23:57 hashes.meta
-rw-r--r--@  1 jsvisa  wheel     6 Oct 27 23:57 hashes.ridx
-rw-r--r--@  1 jsvisa  wheel     0 Oct 27 23:57 headers.0000.cdat
-rw-r--r--@  1 jsvisa  wheel     6 Oct 27 23:57 headers.cidx
-rw-r--r--@  1 jsvisa  wheel     4 Oct 27 23:57 headers.meta
-rw-r--r--@  1 jsvisa  wheel     0 Oct 27 23:57 receipts.0000.cdat
-rw-r--r--@  1 jsvisa  wheel     6 Oct 27 23:57 receipts.cidx
-rw-r--r--@  1 jsvisa  wheel     4 Oct 27 23:57 receipts.meta
drwxr-xr-x@ 18 jsvisa  wheel   576 Oct 27 23:57 state/

And here we changed to use File.Readdirnames instead of File.Readdir, as the first one is more lighter.

@rjl493456442 rjl493456442 added this to the 1.16.6 milestone Oct 28, 2025
@rjl493456442
Copy link
Member

rjl493456442 commented Oct 28, 2025

Thank you.

@rjl493456442 rjl493456442 merged commit b1db341 into ethereum:master Oct 28, 2025
8 of 10 checks passed
@jsvisa jsvisa deleted the legacy-chain-freezer branch October 29, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@fjl fjl Awaiting requested review from fjl fjl is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.16.6

Development

Successfully merging this pull request may close these issues.

2 participants

@jsvisa @rjl493456442