consensus/beacon: fix blob gas error message formatting #33201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
previously approved these changes
Nov 17, 2025
| return fmt.Errorf("invalid excessBlobGas: have %d, expected nil", *header.ExcessBlobGas) | ||
| case header.BlobGasUsed != nil: | ||
| return fmt.Errorf("invalid blobGasUsed: have %d, expected nil", header.BlobGasUsed) | ||
| return fmt.Errorf("invalid blobGasUsed: have %d, expected nil", *header.BlobGasUsed) |
Member
There was a problem hiding this comment.
please also fix for the ParentBeaconRoot
Contributor
Author
There was a problem hiding this comment.
Hi @rjl493456442, done, pls check, thanks!
rizkyikiw42
force-pushed
the
fix/message
branch
2 times, most recently
from
5ac3aa4 to
3b6c2a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error messages to print the actual blob gas value instead of the pointer address by dereferencing
ExcessBlobGasandBlobGasUsed. This aligns with the correct implementation already used in ethash, clique, and eip4844 consensus engines.