disable broken serialization optimizations (#460)

jsign · web-flow · commit af95552ad289 · 2024-10-25T18:31:59.000+02:00
Signed-off-by: Ignacio Hagopian &lt;jsign.uy@gmail.com&gt;
diff --git a/tree.go b/tree.go
@@ -1845,7 +1845,7 @@ func (n *LeafNode) serializeLeafWithUncompressedCommitments(cBytes, c1Bytes, c2B
 	children := make([]byte, 0, NodeWidth*LeafValueSize)
 	var (
 		bitlist        [bitlistSize]byte
-		isEoA          = true
+		isEoA          = false // TODO: EoA serialization optimization is broken -- re-enable when fixed.
 		count, lastIdx int
 	)
 	for i, v := range n.values {
@@ -1883,6 +1883,9 @@ func (n *LeafNode) serializeLeafWithUncompressedCommitments(cBytes, c1Bytes, c2B
 		}
 	}
 
+	// TODO: single slot serialization optimization is apparently broken -- force disabling it until is fixed.
+	count = 256
+
 	// Create the serialization.
 	var result []byte
 	switch {

Original file line number	Diff line number	Diff line change
`@@ -1845,7 +1845,7 @@ func (n *LeafNode) serializeLeafWithUncompressedCommitments(cBytes, c1Bytes, c2B`
`1845`	`1845`	`children := make([]byte, 0, NodeWidth*LeafValueSize)`
`1846`	`1846`	`var (`
`1847`	`1847`	`bitlist [bitlistSize]byte`
`1848`		`- isEoA = true`
	`1848`	`+ isEoA = false // TODO: EoA serialization optimization is broken -- re-enable when fixed.`
`1849`	`1849`	`count, lastIdx int`
`1850`	`1850`	`)`
`1851`	`1851`	`for i, v := range n.values {`
`@@ -1883,6 +1883,9 @@ func (n *LeafNode) serializeLeafWithUncompressedCommitments(cBytes, c1Bytes, c2B`
`1883`	`1883`	`}`
`1884`	`1884`	`}`
`1885`	`1885`
	`1886`	`+ // TODO: single slot serialization optimization is apparently broken -- force disabling it until is fixed.`
	`1887`	`+ count = 256`
	`1888`	`+`
`1886`	`1889`	`// Create the serialization.`
`1887`	`1890`	`var result []byte`
`1888`	`1891`	`switch {`