Apply suggestions from code review

Author: marioevz

hivesim/hive.go

@@ -215,7 +215,7 @@ func (sim *Simulation) StartSharedClient(testSuite SuiteID, clientType string, o
 		return "", nil, errors.New("StartSharedClient is not supported in docs mode")
 	}
 	var (
-		url  = fmt.Sprintf("%s/testsuite/%d/shared-client", sim.url, testSuite)
+		url  = fmt.Sprintf("%s/testsuite/%d/node", sim.url, testSuite)
 		resp simapi.StartNodeResponse
 	)
 
@@ -249,7 +249,7 @@ func (sim *Simulation) GetSharedClientInfo(testSuite SuiteID, clientID string) (
 		return nil, errors.New("GetSharedClientInfo is not supported in docs mode")
 	}
 	var (
-		url  = fmt.Sprintf("%s/testsuite/%d/shared-client/%s", sim.url, testSuite, clientID)
+		url  = fmt.Sprintf("%s/testsuite/%d/node/%s", sim.url, testSuite, clientID)
 		resp SharedClientInfo
 	)
 	err := get(url, &resp)
@@ -263,7 +263,7 @@ func (sim *Simulation) GetClientLogOffset(testSuite SuiteID, clientID string) (i
 		return 0, errors.New("GetClientLogOffset is not supported in docs mode")
 	}
 	var (
-		url  = fmt.Sprintf("%s/testsuite/%d/shared-client/%s/log-offset", sim.url, testSuite, clientID)
+		url  = fmt.Sprintf("%s/testsuite/%d/node/%s/log-offset", sim.url, testSuite, clientID)
 		resp int64
 	)
 	err := get(url, &resp)
@@ -276,7 +276,7 @@ func (sim *Simulation) ExecSharedClient(testSuite SuiteID, clientID string, cmd
 		return nil, errors.New("ExecSharedClient is not supported in docs mode")
 	}
 	var (
-		url  = fmt.Sprintf("%s/testsuite/%d/shared-client/%s/exec", sim.url, testSuite, clientID)
+		url  = fmt.Sprintf("%s/testsuite/%d/node/%s/exec", sim.url, testSuite, clientID)
 		req  = &simapi.ExecRequest{Command: cmd}
 		resp *ExecInfo
 	)

hivesim/shared_client_test.go

@@ -21,13 +21,13 @@ func TestStartSharedClient(t *testing.T) {
 		case "/testsuite":
 			// StartSuite
 			json.NewEncoder(w).Encode(0) // Return suite ID
-		case "/testsuite/0/shared-client":
+		case "/testsuite/0/node":
 			// StartSharedClient
 			json.NewEncoder(w).Encode(simapi.StartNodeResponse{
 				ID: "container1",
 				IP: "192.0.2.1",
 			})
-		case "/testsuite/0/shared-client/container1":
+		case "/testsuite/0/node/container1":
 			// GetSharedClientInfo
 			json.NewEncoder(w).Encode(simapi.NodeResponse{
 				ID:   "container1",
@@ -148,18 +148,18 @@ func TestSharedClientLogOffset(t *testing.T) {
 		case "/testsuite":
 			// StartSuite
 			json.NewEncoder(w).Encode(0) // Return suite ID
-		case "/testsuite/0/shared-client":
+		case "/testsuite/0/node":
 			// StartSharedClient
 			json.NewEncoder(w).Encode(simapi.StartNodeResponse{
 				ID: "container1",
 				IP: "192.0.2.1",
 			})
-		case "/testsuite/0/shared-client/container1/log-offset":
+		case "/testsuite/0/node/container1/log-offset":
 			// GetClientLogOffset - increment the offset each time it's called
 			currentOffset := offsetValue
 			offsetValue += 100 // Simulate log growth
 			json.NewEncoder(w).Encode(currentOffset)
-		case "/testsuite/0/shared-client/container1/exec":
+		case "/testsuite/0/node/container1/exec":
 			// ExecSharedClient
 			json.NewEncoder(w).Encode(&ExecInfo{
 				Stdout:   "test output",
@@ -254,13 +254,13 @@ func TestGetClientLogOffset(t *testing.T) {
 		case "/testsuite":
 			// StartSuite
 			json.NewEncoder(w).Encode(0) // Return suite ID
-		case "/testsuite/0/shared-client":
+		case "/testsuite/0/node":
 			// StartSharedClient
 			json.NewEncoder(w).Encode(simapi.StartNodeResponse{
 				ID: "container1",
 				IP: "192.0.2.1",
 			})
-		case "/testsuite/0/shared-client/container1/log-offset":
+		case "/testsuite/0/node/container1/log-offset":
 			// GetClientLogOffset
 			json.NewEncoder(w).Encode(int64(0)) // Initial log offset
 		default:

internal/libhive/api.go

@@ -43,11 +43,11 @@ func newSimulationAPI(b ContainerBackend, env SimEnv, tm *TestManager, hive Hive
 	router.HandleFunc("/testsuite/{suite}/test/{test}", api.endTest).Methods("POST")
 
 	// Shared client routes
-	router.HandleFunc("/testsuite/{suite}/shared-client", api.startSharedClient).Methods("POST")
-	router.HandleFunc("/testsuite/{suite}/shared-client/{node}", api.getSharedClientInfo).Methods("GET")
-	router.HandleFunc("/testsuite/{suite}/shared-client/{node}/log-offset", api.getSharedClientLogOffset).Methods("GET")
-	router.HandleFunc("/testsuite/{suite}/shared-client/{node}/exec", api.execInSharedClient).Methods("POST")
-	router.HandleFunc("/testsuite/{suite}/shared-client/{node}", api.stopSharedClient).Methods("DELETE")
+	router.HandleFunc("/testsuite/{suite}/node", api.startSharedClient).Methods("POST")
+	router.HandleFunc("/testsuite/{suite}/node/{node}", api.getSharedClientInfo).Methods("GET")
+	router.HandleFunc("/testsuite/{suite}/node/{node}/log-offset", api.getSharedClientLogOffset).Methods("GET")
+	router.HandleFunc("/testsuite/{suite}/node/{node}/exec", api.execInSharedClient).Methods("POST")
+	router.HandleFunc("/testsuite/{suite}/node/{node}", api.stopSharedClient).Methods("DELETE")
 
 	// Regular client routes
 	router.HandleFunc("/testsuite/{suite}/test/{test}/node/{node}/exec", api.execInClient).Methods("POST")