Skip to content

Commit 9a292c8

Browse files
committed
Fix tests
1 parent 02d11a7 commit 9a292c8

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"dependencies": {
2727
"micro-base": "^0.10.1",
2828
"@noble/hashes": "^0.5.7",
29-
"@noble/secp256k1": "^1.3.3"
29+
"@noble/secp256k1": "^1.4.0"
3030
},
3131
"browser": {
3232
"crypto": false

src/secp256k1-compat.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,13 +150,14 @@ export function ecdsaVerify(
150150
if (r >= ORDER || s >= ORDER) {
151151
throw new Error("Cannot parse signature");
152152
}
153+
const pub = secp.Point.fromHex(publicKey); // should not throw error
153154
let sig;
154155
try {
155156
sig = getSignature(signature);
156157
} catch (error) {
157158
return false;
158159
}
159-
return secp.verify(sig, msgHash, publicKey);
160+
return secp.verify(sig, msgHash, pub);
160161
}
161162

162163
export function privateKeyTweakAdd(

test/test-vectors/secp256k1.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import * as secp from "../../src/secp256k1";
22
import { deepStrictEqual } from "./assert";
33

4-
describe("curve-secp256k1", () => {
4+
describe("secp256k1", () => {
55
it("should verify msg bb5a...", async () => {
66
const msg =
77
"bb5a52f42f9c9261ed4361f59422a1e30036e7c32b270c8807a419feca605023";
@@ -11,6 +11,6 @@ describe("curve-secp256k1", () => {
1111
const s = 115792089237316195423570985008687907852837564279074904382605163141518161494334n;
1212
const pub = new secp.Point(x, y);
1313
const sig = new secp.Signature(r, s);
14-
deepStrictEqual(secp.verify(sig, msg, pub), true);
14+
deepStrictEqual(secp.verify(sig, msg, pub, { strict: false }), true);
1515
});
1616
});

0 commit comments

Comments
 (0)