From f57c3d39b8a148af558e4ff2e738d28469e5b7ec Mon Sep 17 00:00:00 2001 From: acolytec3 <17355484+acolytec3@users.noreply.github.com> Date: Mon, 25 Jul 2022 14:59:01 -0400 Subject: [PATCH 1/4] Revert changes --- history-network.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/history-network.md b/history-network.md index 6c5737ea..62aa60de 100644 --- a/history-network.md +++ b/history-network.md @@ -206,11 +206,9 @@ ssz_uncles = SSZList(encoded_uncles: Byte, max_length=MAX_ENCODED_U encoded_uncles = rlp.encode(list_of_uncle_headers) ``` -Note 1: The type-specific encoding might be different in future transaction types, but this encoding +Note the type-specific encoding might be different in future transaction types, but this encoding works for all current transaction types. -Note 2: The `list_of_uncle_headers` refers to the array of uncle headers [defined in the devp2p spec](https://github.com/ethereum/devp2p/blob/master/caps/eth.md#block-encoding-and-validity). - #### Receipts ``` From d5092ac6b47bb8c1a18c8adb3ab19825b1286c41 Mon Sep 17 00:00:00 2001 From: acolytec3 <17355484+acolytec3@users.noreply.github.com> Date: Mon, 25 Jul 2022 14:59:24 -0400 Subject: [PATCH 2/4] Add clarifying note --- history-network.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/history-network.md b/history-network.md index 62aa60de..6c5737ea 100644 --- a/history-network.md +++ b/history-network.md @@ -206,9 +206,11 @@ ssz_uncles = SSZList(encoded_uncles: Byte, max_length=MAX_ENCODED_U encoded_uncles = rlp.encode(list_of_uncle_headers) ``` -Note the type-specific encoding might be different in future transaction types, but this encoding +Note 1: The type-specific encoding might be different in future transaction types, but this encoding works for all current transaction types. +Note 2: The `list_of_uncle_headers` refers to the array of uncle headers [defined in the devp2p spec](https://github.com/ethereum/devp2p/blob/master/caps/eth.md#block-encoding-and-validity). + #### Receipts ``` From 1bd0e8323473c5ecd976925f1913e3bce90ff775 Mon Sep 17 00:00:00 2001 From: acolytec3 <17355484+acolytec3@users.noreply.github.com> Date: Tue, 26 Jul 2022 10:46:26 -0400 Subject: [PATCH 3/4] Revise reference and note --- history-network.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/history-network.md b/history-network.md index 6c5737ea..56f85ed2 100644 --- a/history-network.md +++ b/history-network.md @@ -209,7 +209,7 @@ encoded_uncles = rlp.encode(list_of_uncle_headers) Note 1: The type-specific encoding might be different in future transaction types, but this encoding works for all current transaction types. -Note 2: The `list_of_uncle_headers` refers to the array of uncle headers [defined in the devp2p spec](https://github.com/ethereum/devp2p/blob/master/caps/eth.md#block-encoding-and-validity). +Note 2: The `list_of_uncle_headers` refers to the list of uncle headers [defined in the Ethereum yellow paper](https://github.com/ethereum/yellowpaper/blob/30782852fef61f61a247dafbdad814ae7e00fb39/Paper.tex#L399) and is represented as an array of byte arrays where each byte array is the raw bytes representing an uncle header. #### Receipts From 65219fc6566349f9ff4c99743c5127faa44f76aa Mon Sep 17 00:00:00 2001 From: acolytec3 <17355484+acolytec3@users.noreply.github.com> Date: Thu, 11 Aug 2022 11:16:31 -0400 Subject: [PATCH 4/4] Update history-network.md Co-authored-by: Jason Carver --- history-network.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/history-network.md b/history-network.md index 56f85ed2..d8a62b2c 100644 --- a/history-network.md +++ b/history-network.md @@ -209,7 +209,7 @@ encoded_uncles = rlp.encode(list_of_uncle_headers) Note 1: The type-specific encoding might be different in future transaction types, but this encoding works for all current transaction types. -Note 2: The `list_of_uncle_headers` refers to the list of uncle headers [defined in the Ethereum yellow paper](https://github.com/ethereum/yellowpaper/blob/30782852fef61f61a247dafbdad814ae7e00fb39/Paper.tex#L399) and is represented as an array of byte arrays where each byte array is the raw bytes representing an uncle header. +Note 2: The `list_of_uncle_headers` refers to the list of uncle headers [defined in the Ethereum yellow paper](https://github.com/ethereum/yellowpaper/blob/30782852fef61f61a247dafbdad814ae7e00fb39/Paper.tex#L414). As usual, when encoding to RLP, each header must first be formatted as a list where each field is represented as an integer or byte-string. So `list_of_uncle_headers` is a list of these lists, before rlp-encoding. #### Receipts