Add London opcode tests

Validation of London header gas limit was missing, which caused an
infinite loop when trying to fill up a block (it never filled!).

So, added validation of London headers: gas_used <= gas_limit

Author: carver

eth/vm/forks/london/__init__.py

@@ -36,8 +36,6 @@ class LondonVM(BerlinVM):
     all_header_sedes: Type[BlockHeaderSedesAPI] = LondonBackwardsHeader
 
     # Methods
-    # skip header validation: validate everything in the executor as we need state access
-    validate_transaction_against_header = lambda *_: None  # type: ignore
     create_header_from_parent = staticmethod(create_london_header_from_parent)  # type: ignore
     compute_difficulty = staticmethod(compute_london_difficulty)    # type: ignore
     # configure_header = configure_berlin_header

tests/core/chain-object/test_gas_estimation.py

@@ -755,6 +755,78 @@
             22272,
             id='sha3 precompile 32 bytes 1000_tolerance binary pending for BerlinVM',
         ),
+        pytest.param(
+            b'',
+            None,
+            ADDR_1010,
+            True,
+            LondonVM,
+            21000,
+            id='simple default pending for LondonVM',
+        ),
+        pytest.param(
+            b'',
+            None,
+            ADDR_1010,
+            False,
+            LondonVM,
+            21000,
+            id='simple default for LondonVM',
+        ),
+        pytest.param(
+            b'\xff' * 10,
+            None,
+            ADDR_1010,
+            True,
+            LondonVM,
+            21160,
+            id='10 bytes default pending for LondonVM',
+        ),
+        pytest.param(
+            b'\xff' * 10,
+            None,
+            ADDR_1010,
+            False,
+            LondonVM,
+            21160,
+            id='10 bytes default for LondonVM',
+        ),
+        pytest.param(
+            b'\xff' * 32,
+            None,
+            ADDRESS_2,
+            True,
+            LondonVM,
+            33675,
+            id='sha3 precompile 32 bytes default pending for LondonVM',
+        ),
+        pytest.param(
+            b'\xff' * 32,
+            None,
+            ADDRESS_2,
+            False,
+            LondonVM,
+            33687,
+            id='sha3 precompile 32 bytes default for LondonVM',
+        ),
+        pytest.param(
+            b'\xff' * 320,
+            None,
+            ADDRESS_2,
+            True,
+            LondonVM,
+            38265,
+            id='sha3 precompile 320 bytes default pending for LondonVM',
+        ),
+        pytest.param(
+            b'\xff' * 32,
+            binary_gas_search_1000_tolerance,
+            ADDRESS_2,
+            True,
+            LondonVM,
+            22272,
+            id='sha3 precompile 32 bytes 1000_tolerance binary pending for LondonVM',
+        ),
     ),
 )
 def test_estimate_gas(
@@ -816,6 +888,7 @@ def test_estimate_gas(
         (IstanbulVM, 186120),
         (MuirGlacierVM, 186120),
         (BerlinVM, 186120),
+        (LondonVM, 186120),
     )
 )
 def test_estimate_gas_on_full_block(

tests/core/helpers.py

@@ -36,5 +36,9 @@ def fill_block(chain, from_, key, gas, data):
                 break
             else:
                 raise exc
+        else:
+            new_header = chain.get_vm().get_block().header
+            assert new_header.gas_used > 0
+            assert new_header.gas_used <= new_header.gas_limit
 
     assert chain.get_vm().get_block().header.gas_used > 0