Skip to content

Commit 396ec8a

Browse files
committed
Use eth constant instead of 1024 in gas limit test
1 parent 65fdff7 commit 396ec8a

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

tests/core/vm/test_vm.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,8 @@ def test_validate_gas_limit_almost_too_low(noproof_consensus_chain):
133133
block1 = noproof_consensus_chain.mine_block()
134134
block2 = noproof_consensus_chain.mine_block()
135135

136-
barely_valid_low_gas_limit = block1.header.gas_limit - (block1.header.gas_limit // 1024)
136+
max_reduction = block1.header.gas_limit // constants.GAS_LIMIT_ADJUSTMENT_FACTOR
137+
barely_valid_low_gas_limit = block1.header.gas_limit - max_reduction
137138
barely_valid_header = block2.header.copy(gas_limit=barely_valid_low_gas_limit)
138139

139140
vm = noproof_consensus_chain.get_vm(block2.header)
@@ -145,7 +146,8 @@ def test_validate_gas_limit_too_low(noproof_consensus_chain):
145146
block1 = noproof_consensus_chain.mine_block()
146147
block2 = noproof_consensus_chain.mine_block()
147148

148-
invalid_low_gas_limit = block1.header.gas_limit - (block1.header.gas_limit // 1024) - 1
149+
max_reduction = block1.header.gas_limit // constants.GAS_LIMIT_ADJUSTMENT_FACTOR
150+
invalid_low_gas_limit = block1.header.gas_limit - max_reduction - 1
149151
invalid_header = block2.header.copy(gas_limit=invalid_low_gas_limit)
150152

151153
vm = noproof_consensus_chain.get_vm(block2.header)
@@ -158,7 +160,8 @@ def test_validate_gas_limit_almost_too_high(noproof_consensus_chain):
158160
block1 = noproof_consensus_chain.mine_block()
159161
block2 = noproof_consensus_chain.mine_block()
160162

161-
barely_valid_high_gas_limit = block1.header.gas_limit + (block1.header.gas_limit // 1024)
163+
max_increase = block1.header.gas_limit // constants.GAS_LIMIT_ADJUSTMENT_FACTOR
164+
barely_valid_high_gas_limit = block1.header.gas_limit + max_increase
162165
barely_valid_header = block2.header.copy(gas_limit=barely_valid_high_gas_limit)
163166

164167
vm = noproof_consensus_chain.get_vm(block2.header)
@@ -170,7 +173,8 @@ def test_validate_gas_limit_too_high(noproof_consensus_chain):
170173
block1 = noproof_consensus_chain.mine_block()
171174
block2 = noproof_consensus_chain.mine_block()
172175

173-
invalid_high_gas_limit = block1.header.gas_limit + (block1.header.gas_limit // 1024) + 1
176+
max_increase = block1.header.gas_limit // constants.GAS_LIMIT_ADJUSTMENT_FACTOR
177+
invalid_high_gas_limit = block1.header.gas_limit + max_increase + 1
174178
invalid_header = block2.header.copy(gas_limit=invalid_high_gas_limit)
175179

176180
vm = noproof_consensus_chain.get_vm(block2.header)

0 commit comments

Comments
 (0)