Skip to content

Commit 3b3338c

Browse files
committed
Ensure a target number of validators rather than rely on the fixture
1 parent bcdf4e3 commit 3b3338c

File tree

1 file changed

+23
-7
lines changed

1 file changed

+23
-7
lines changed

tests/beacon/test_helpers.py

Lines changed: 23 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -822,11 +822,9 @@ def _get_indices_and_signatures(num_validators, message, privkeys, fork_data, sl
822822
return (indices, signatures)
823823

824824

825-
def _correct_slashable_vote_data_params(params, validators, messages, privkeys, fork_data):
825+
def _correct_slashable_vote_data_params(num_validators, params, messages, privkeys, fork_data):
826826
valid_params = copy.deepcopy(params)
827827

828-
num_validators = len(validators)
829-
830828
key = "custody_bit_0_indices"
831829
(poc_0_indices, poc_0_signatures) = _get_indices_and_signatures(
832830
num_validators,
@@ -890,7 +888,16 @@ def _create_slashable_vote_data_messages(params):
890888
return votes.messages
891889

892890

893-
def test_verify_slashable_vote_data_signature(privkeys,
891+
@pytest.mark.parametrize(
892+
(
893+
'num_validators',
894+
),
895+
[
896+
(40,),
897+
]
898+
)
899+
def test_verify_slashable_vote_data_signature(num_validators,
900+
privkeys,
894901
sample_beacon_state_params,
895902
genesis_validators,
896903
sample_slashable_vote_data_params,
@@ -913,8 +920,8 @@ def test_verify_slashable_vote_data_signature(privkeys,
913920

914921
fork_data = ForkData(**sample_fork_data_params)
915922
valid_params = _correct_slashable_vote_data_params(
923+
num_validators,
916924
sample_slashable_vote_data_params,
917-
genesis_validators,
918925
messages,
919926
privkeys,
920927
fork_data,
@@ -936,6 +943,14 @@ def _run_verify_slashable_vote(params, state, max_casper_votes, should_succeed):
936943
assert not result
937944

938945

946+
@pytest.mark.parametrize(
947+
(
948+
'num_validators',
949+
),
950+
[
951+
(40,),
952+
]
953+
)
939954
@pytest.mark.parametrize(
940955
(
941956
'param_mapper',
@@ -951,7 +966,8 @@ def _run_verify_slashable_vote(params, state, max_casper_votes, should_succeed):
951966
), False, True),
952967
],
953968
)
954-
def test_verify_slashable_vote_data(param_mapper,
969+
def test_verify_slashable_vote_data(num_validators,
970+
param_mapper,
955971
should_succeed,
956972
needs_fork_data,
957973
privkeys,
@@ -978,8 +994,8 @@ def test_verify_slashable_vote_data(param_mapper,
978994

979995
fork_data = ForkData(**sample_fork_data_params)
980996
params = _correct_slashable_vote_data_params(
997+
num_validators,
981998
sample_slashable_vote_data_params,
982-
genesis_validators,
983999
messages,
9841000
privkeys,
9851001
fork_data,

0 commit comments

Comments
 (0)