Get rid of TrinityStartupEvent

Author: cburgdorf

trinity/extensibility/events.py

@@ -29,15 +29,6 @@ class BaseEvent:
     pass
 
 
-class TrinityStartupEvent(BaseEvent):
-    """
-    Broadcasted when Trinity is starting.
-    """
-    def __init__(self, args: Namespace, trinity_config: TrinityConfig) -> None:
-        self.args = args
-        self.trinity_config = trinity_config
-
-
 class PluginStartedEvent(BaseEvent):
     """
     Broadcasted when a plugin was started

trinity/main.py

@@ -49,9 +49,6 @@
     PluginManager,
     SharedProcessScope,
 )
-from trinity.extensibility.events import (
-    TrinityStartupEvent
-)
 from trinity.plugins.registry import (
     ENABLED_PLUGINS
 )
@@ -270,10 +267,7 @@ def trinity_boot(args: Namespace,
     )
 
     plugin_manager.prepare(args, trinity_config, extra_kwargs)
-    plugin_manager.broadcast(TrinityStartupEvent(
-        args,
-        trinity_config
-    ))
+
     try:
         loop = asyncio.get_event_loop()
         loop.run_forever()
@@ -361,10 +355,6 @@ def launch_node(args: Namespace, trinity_config: TrinityConfig, endpoint: Endpoi
 
         plugin_manager = setup_plugins(SharedProcessScope(endpoint))
         plugin_manager.prepare(args, trinity_config)
-        plugin_manager.broadcast(TrinityStartupEvent(
-            args,
-            trinity_config
-        ))
 
         node = NodeClass(plugin_manager, trinity_config)
         loop = node.get_event_loop()

trinity/plugins/builtin/tx_pool/plugin.py

@@ -27,7 +27,6 @@
 )
 from trinity.extensibility.events import (
     ResourceAvailableEvent,
-    TrinityStartupEvent,
 )
 from trinity.plugins.builtin.tx_pool.pool import (
     TxPool,
@@ -57,12 +56,16 @@ def configure_parser(self, arg_parser: ArgumentParser, subparser: _SubParsersAct
         )
 
     def handle_event(self, activation_event: BaseEvent) -> None:
-        if isinstance(activation_event, TrinityStartupEvent):
-            light_mode = activation_event.args.sync_mode == SYNC_LIGHT
-            self.is_enabled = activation_event.args.tx_pool and not light_mode
-            if activation_event.args.tx_pool and light_mode:
-                self.logger.error('The transaction pool is not yet available in light mode')
-                self.context.shutdown_host()
+
+        light_mode = self.context.chain_config.sync_mode == SYNC_LIGHT
+        self.is_enabled = self.context.args.tx_pool and not light_mode
+
+        unsupported = self.context.args.tx_pool and light_mode
+
+        if unsupported:
+            self.logger.error('The transaction pool is not yet available in light mode')
+            self.context.shutdown_host()
+
         if isinstance(activation_event, ResourceAvailableEvent):
             if activation_event.resource_type is ETHPeerPool:
                 self.peer_pool, self.cancel_token = activation_event.resource