Add some more tests for Rewards

Bhargavasomu · cburgdorf · commit 6657dfef7d53 · 2019-01-23T16:43:33.000+01:00
diff --git a/tests/core/vm/test_rewards.py b/tests/core/vm/test_rewards.py
@@ -1,7 +1,8 @@
 import pytest
 
 from eth_utils import (
-    to_wei
+    to_wei,
+    ValidationError,
 )
 
 from eth.chains.base import (
@@ -12,6 +13,7 @@
     build,
     disable_pow_check,
     mine_block,
+    mine_blocks,
     byzantium_at,
     frontier_at,
     homestead_at,
@@ -82,3 +84,215 @@ def test_rewards(vm_fn, miner_1_balance, miner_2_balance):
     # But we also ensure the balance matches the numbers that we calculated on paper
     assert coinbase_balance == to_wei(miner_1_balance, 'ether')
     assert other_miner_balance == to_wei(miner_2_balance, 'ether')
+
+
+@pytest.mark.parametrize(
+    'vm_fn, fork_at_block_number, miner_1_balance, miner_2_balance',
+    (
+        (frontier_at, 3, 50.15625, 1.25),
+        (frontier_at, 4, 50.15625, 1.875),
+        (frontier_at, 5, 50.15625, 2.5),
+        (frontier_at, 6, 50.15625, 3.125),
+        (frontier_at, 7, 50.15625, 3.75),
+        (frontier_at, 8, 50.15625, 4.375),
+
+        (homestead_at, 3, 50.15625, 1.25),
+        (homestead_at, 4, 50.15625, 1.875),
+        (homestead_at, 5, 50.15625, 2.5),
+        (homestead_at, 6, 50.15625, 3.125),
+        (homestead_at, 7, 50.15625, 3.75),
+        (homestead_at, 8, 50.15625, 4.375),
+
+        (tangerine_whistle_at, 3, 50.15625, 1.25),
+        (tangerine_whistle_at, 4, 50.15625, 1.875),
+        (tangerine_whistle_at, 5, 50.15625, 2.5),
+        (tangerine_whistle_at, 6, 50.15625, 3.125),
+        (tangerine_whistle_at, 7, 50.15625, 3.75),
+        (tangerine_whistle_at, 8, 50.15625, 4.375),
+
+        (spurious_dragon_at, 3, 50.15625, 1.25),
+        (spurious_dragon_at, 4, 50.15625, 1.875),
+        (spurious_dragon_at, 5, 50.15625, 2.5),
+        (spurious_dragon_at, 6, 50.15625, 3.125),
+        (spurious_dragon_at, 7, 50.15625, 3.75),
+        (spurious_dragon_at, 8, 50.15625, 4.375),
+
+        (byzantium_at, 3, 30.09375, 0.75),
+        (byzantium_at, 4, 30.09375, 1.125),
+        (byzantium_at, 5, 30.09375, 1.5),
+        (byzantium_at, 6, 30.09375, 1.875),
+        (byzantium_at, 7, 30.09375, 2.25),
+        (byzantium_at, 8, 30.09375, 2.625),
+
+        (constantinople_at, 3, 20.0625, 0.5),
+        (constantinople_at, 4, 20.0625, 0.75),
+        (constantinople_at, 5, 20.0625, 1),
+        (constantinople_at, 6, 20.0625, 1.25),
+        (constantinople_at, 7, 20.0625, 1.5),
+        (constantinople_at, 8, 20.0625, 1.75),
+    )
+)
+def test_rewards_uncle_created_at_different_generations(
+        vm_fn,
+        fork_at_block_number,
+        miner_1_balance,
+        miner_2_balance):
+    OTHER_MINER_ADDRESS = 20 * b'\x01'
+    TOTAL_BLOCKS_CANONICAL_CHAIN = 10
+
+    chain = build(
+        MiningChain,
+        vm_fn(0),
+        disable_pow_check(),
+        genesis(),
+        mine_blocks(TOTAL_BLOCKS_CANONICAL_CHAIN - 1),
+    )
+
+    fork_chain = build(
+        chain,
+        at_block_number(fork_at_block_number),
+        mine_block(extra_data=b'fork-it!', coinbase=OTHER_MINER_ADDRESS),  # fork 2
+    )
+
+    # we don't use canonical head here because the fork chain is non-canonical.
+    uncle = fork_chain.get_block_header_by_hash(fork_chain.header.parent_hash)
+    assert uncle.block_number == fork_at_block_number + 1
+
+    chain = build(
+        chain,
+        mine_block(uncles=[uncle]),
+    )
+
+    header = chain.get_canonical_head()
+    block = chain.get_block_by_hash(header.hash)
+
+    vm = chain.get_vm()
+    coinbase_balance = vm.state.account_db.get_balance(block.header.coinbase)
+    other_miner_balance = vm.state.account_db.get_balance(uncle.coinbase)
+
+    # We first test if the balance matches what we would determine
+    # if we made all the API calls involved ourselves.
+    assert coinbase_balance == (vm.get_block_reward() *
+                                TOTAL_BLOCKS_CANONICAL_CHAIN +
+                                vm.get_nephew_reward())
+
+    assert other_miner_balance == vm.get_uncle_reward(block.number, uncle)
+
+    # But we also ensure the balance matches the numbers that we calculated on paper
+    assert coinbase_balance == to_wei(miner_1_balance, 'ether')
+    assert other_miner_balance == to_wei(miner_2_balance, 'ether')
+
+
+@pytest.mark.parametrize(
+    'vm_fn',
+    (
+        frontier_at,
+        homestead_at,
+        tangerine_whistle_at,
+        spurious_dragon_at,
+        byzantium_at,
+        constantinople_at,
+    )
+)
+def test_uncle_block_inclusion_validity(vm_fn):
+    # This test ensures that a forked block which is behind by
+    # more than 6 layers cannot act as an ancestor to the current block
+
+    OTHER_MINER_ADDRESS = 20 * b'\x01'
+
+    chain = build(
+        MiningChain,
+        vm_fn(0),
+        disable_pow_check(),
+        genesis(),
+        mine_block(),  # 1
+        mine_block(),  # 2
+    )
+
+    fork_chain = build(
+        chain,
+        at_block_number(1),
+        mine_block(extra_data=b'fork-it!', coinbase=OTHER_MINER_ADDRESS),  # fork 2
+    )
+
+    # we don't use canonical head here because the fork chain is non-canonical.
+    uncle = fork_chain.get_block_header_by_hash(fork_chain.header.parent_hash)
+    assert uncle.block_number == 2
+
+    with pytest.raises(ValidationError):
+        chain = build(
+            chain,
+            # Mines blocks from 3 to 8 (both numbers inclusive)
+            mine_blocks(6),
+            # Mine block 9 with uncle
+            mine_block(uncles=[uncle]),
+        )
+
+
+@pytest.mark.parametrize(
+    'vm_fn_uncle, vm_fn_nephew, miner_1_balance, miner_2_balance',
+    (
+        (frontier_at, homestead_at, 50.15625, 1.25),
+        (homestead_at, tangerine_whistle_at, 50.15625, 1.25),
+        (tangerine_whistle_at, spurious_dragon_at, 50.15625, 1.25),
+        (spurious_dragon_at, byzantium_at, 36.09375, 0.75),
+        (byzantium_at, constantinople_at, 23.0625, 0.5),
+    )
+)
+def test_rewards_nephew_uncle_different_vm(
+        vm_fn_uncle,
+        vm_fn_nephew,
+        miner_1_balance,
+        miner_2_balance):
+    OTHER_MINER_ADDRESS = 20 * b'\x01'
+    TOTAL_BLOCKS_CANONICAL_CHAIN = 10
+    VM_CHANGE_BLOCK_NUMBER = 4
+
+    chain = build(
+        MiningChain,
+        vm_fn_uncle(0),
+        vm_fn_nephew(VM_CHANGE_BLOCK_NUMBER),
+        disable_pow_check(),
+        genesis(),
+        mine_blocks(TOTAL_BLOCKS_CANONICAL_CHAIN - 1),
+    )
+
+    fork_chain = build(
+        chain,
+        at_block_number(3),
+        mine_block(extra_data=b'fork-it!', coinbase=OTHER_MINER_ADDRESS),  # fork 2
+    )
+
+    # we don't use canonical head here because the fork chain is non-canonical.
+    uncle = fork_chain.get_block_header_by_hash(fork_chain.header.parent_hash)
+    assert uncle.block_number == 4
+
+    chain = build(
+        chain,
+        mine_block(uncles=[uncle]),
+    )
+
+    header = chain.get_canonical_head()
+    block = chain.get_block_by_hash(header.hash)
+    assert len(block.uncles) == 1
+    assert block.uncles[0] == uncle
+
+    vm = chain.get_vm()
+    coinbase_balance = vm.state.account_db.get_balance(block.header.coinbase)
+    other_miner_balance = vm.state.account_db.get_balance(uncle.coinbase)
+
+    uncle_vm = chain.get_vm_class_for_block_number(0)
+    nephew_vm = chain.get_vm_class_for_block_number(VM_CHANGE_BLOCK_NUMBER)
+
+    # We first test if the balance matches what we would determine
+    # if we made all the API calls involved ourselves.
+    assert coinbase_balance == (
+        uncle_vm.get_block_reward() * 3 +
+        nephew_vm.get_block_reward() * (TOTAL_BLOCKS_CANONICAL_CHAIN - 3) +
+        vm.get_nephew_reward()
+    )
+    assert other_miner_balance == vm.get_uncle_reward(block.number, uncle)
+
+    # But we also ensure the balance matches the numbers that we calculated on paper
+    assert coinbase_balance == to_wei(miner_1_balance, 'ether')
+    assert other_miner_balance == to_wei(miner_2_balance, 'ether')
