Remove unused add_uncle API

cburgdorf · Peppece · commit 6f4aa27a87cc · 2020-10-12T23:01:56.000+02:00
diff --git a/eth/vm/forks/frontier/blocks.py b/eth/vm/forks/frontier/blocks.py
@@ -4,7 +4,6 @@
     Type,
 )
 
-import rlp
 from rlp.sedes import (
     CountableList,
 )
@@ -18,7 +17,6 @@
     Hash32,
 )
 
-from eth_hash.auto import keccak
 from trie.exceptions import (
     MissingTrieNode,
 )
@@ -131,11 +129,3 @@ def from_header(cls, header: BlockHeaderAPI, chaindb: ChainDatabaseAPI) -> "Fron
             transactions=transactions,
             uncles=uncles,
         )
-
-    #
-    # Execution API
-    #
-    def add_uncle(self, uncle: BlockHeaderAPI) -> "FrontierBlock":
-        self.uncles += (uncle,)
-        self.header.uncles_hash = keccak(rlp.encode(self.uncles))
-        return self
diff --git a/newsfragments/1949.removal.rst b/newsfragments/1949.removal.rst
@@ -0,0 +1,2 @@
+Removed unused and broken ``add_uncle` API on ``FrontierBlock`` and
+consequentially on all other derived block classes.

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@`
`4`	`4`	`Type,`
`5`	`5`	`)`
`6`	`6`
`7`		`-import rlp`
`8`	`7`	`from rlp.sedes import (`
`9`	`8`	`CountableList,`
`10`	`9`	`)`
`@@ -18,7 +17,6 @@`
`18`	`17`	`Hash32,`
`19`	`18`	`)`
`20`	`19`
`21`		`-from eth_hash.auto import keccak`
`22`	`20`	`from trie.exceptions import (`
`23`	`21`	`MissingTrieNode,`
`24`	`22`	`)`
`@@ -131,11 +129,3 @@ def from_header(cls, header: BlockHeaderAPI, chaindb: ChainDatabaseAPI) -> "Fron`
`131`	`129`	`transactions=transactions,`
`132`	`130`	`uncles=uncles,`
`133`	`131`	`)`
`134`		`-`
`135`		`- #`
`136`		`- # Execution API`
`137`		`- #`
`138`		`- def add_uncle(self, uncle: BlockHeaderAPI) -> "FrontierBlock":`
`139`		`- self.uncles += (uncle,)`
`140`		`- self.header.uncles_hash = keccak(rlp.encode(self.uncles))`
`141`		`- return self`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Removed unused and broken ``add_uncle` API on ``FrontierBlock`` and
	`2`	`+consequentially on all other derived block classes.`