Implement peer factory and boot manager (#1286)

* Extract trinity code from p2p module

* fix broken ActivationEvent

* PR feedback

Author: pipermerriam

p2p/constants.py

@@ -39,7 +39,7 @@
 
 # Timeout used when performing the check to ensure peers are on the same side of chain splits as
 # us.
-CHAIN_SPLIT_CHECK_TIMEOUT = 5 * REPLY_TIMEOUT
+CHAIN_SPLIT_CHECK_TIMEOUT = 15
 
 # Default timeout before giving up on a caller-initiated interaction
 COMPLETION_TIMEOUT = 5
@@ -75,3 +75,8 @@
 # (https://github.com/ethereum/go-ethereum/pull/1889#issue-47241762), but in order to err on the
 # side of caution, we use a higher value.
 SEAL_CHECK_RANDOM_SAMPLE_RATE = 48
+
+
+# The amount of time that the BasePeerPool will wait for a peer to boot before
+# aborting the connection attempt.
+DEFAULT_PEER_BOOT_TIMEOUT = 20

p2p/discovery.py

@@ -59,7 +59,7 @@
 from p2p.exceptions import AlreadyWaitingDiscoveryResponse, NoEligibleNodes, UnableToGetDiscV5Ticket
 from p2p import kademlia
 from p2p import protocol
-from p2p.peer import PeerPool
+from p2p.peer import BasePeerPool
 from p2p.service import BaseService
 
 if TYPE_CHECKING:
@@ -948,7 +948,7 @@ class DiscoveryService(BaseService):
     _last_lookup: float = 0
     _lookup_interval: int = 30
 
-    def __init__(self, proto: DiscoveryProtocol, peer_pool: PeerPool,
+    def __init__(self, proto: DiscoveryProtocol, peer_pool: BasePeerPool,
                  port: int, token: CancelToken = None) -> None:
         super().__init__(token)
         self.proto = proto