Re-add validations to get the tests to pass

Author: lithp

eth/validation.py

@@ -51,6 +51,17 @@ def validate_is_bytes(value: bytes, title: str="Value") -> None:
         )
 
 
+def validate_is_bytes_or_view(value: Union[bytes, memoryview],
+                              title: str="Value") -> None:
+    if isinstance(value, bytes):
+        return
+    if isinstance(value, memoryview):
+        return
+    raise ValidationError(
+        "{title} must be bytes or memoryview. Got {0}".format(type(value), title=title)
+    )
+
+
 def validate_is_integer(value: Union[int, bool], title: str="Value") -> None:
     if not isinstance(value, int) or isinstance(value, bool):
         raise ValidationError(

eth/vm/computation.py

@@ -41,6 +41,7 @@
 from eth.validation import (
     validate_canonical_address,
     validate_is_bytes,
+    validate_is_bytes_or_view,
     validate_uint256,
 )
 from eth.vm.code_stream import (
@@ -447,11 +448,11 @@ def add_log_entry(
             account: Address,
             topics: List[int],
             data: Union[bytes, memoryview]) -> None:
-        data = bytes(data)
         validate_canonical_address(account, title="Log entry address")
         for topic in topics:
             validate_uint256(topic, title="Log entry topic")
-        validate_is_bytes(data, title="Log entry data")
+        validate_is_bytes_or_view(data, title="Log entry data")
+        data = bytes(data)
         self._log_entries.append(
             (self.transaction_context.get_next_log_counter(), account, topics, data))
 

eth/vm/message.py

@@ -9,6 +9,7 @@
 from eth.validation import (
     validate_canonical_address,
     validate_is_bytes,
+    validate_is_bytes_or_view,
     validate_is_integer,
     validate_gte,
     validate_uint256,
@@ -52,7 +53,7 @@ def __init__(self,
         validate_uint256(value, title="Message.value")
         self.value = value
 
-#        validate_is_bytes(data, title="Message.data")
+        validate_is_bytes_or_view(data, title="Message.data")
         self.data = data
 
         validate_is_integer(depth, title="Message.depth")