Apply suggestions from code review: update enums

Co-Authored-By: hwwhww <[email protected]>

Author: ChihChengLiang

eth/beacon/enums.py

@@ -4,7 +4,7 @@
 class ValidatorStatusCode(IntEnum):
     PENDING_ACTIVATION = 0
     ACTIVE = 1
-    PENDING_EXIT = 2
+    ACTIVE_PENDING_EXIT = 2
     EXITED_WITHOUT_PENALTY = 3
     EXITED_WITH_PENALTY = 4
 
@@ -18,4 +18,4 @@ class SignatureDomain(IntEnum):
     DOMAIN_DEPOSIT = 0
     DOMAIN_ATTESTATION = 1
     DOMAIN_PROPOSAL = 2
-    DOMAIN_LOGOUT = 3
+    DOMAIN_EXIT = 3

eth/beacon/helpers.py

@@ -156,7 +156,7 @@ def get_active_validator_indices(validators: Sequence['ValidatorRecord']) -> Tup
     """
     return tuple(
         i for i, v in enumerate(validators)
-        if v.status in [ValidatorStatusCode.ACTIVE, ValidatorStatusCode.PENDING_EXIT]
+        if v.status in [ValidatorStatusCode.ACTIVE, ValidatorStatusCode.ACTIVE_PENDING_EXIT]
     )
 
 

tests/beacon/test_helpers.py

@@ -503,14 +503,14 @@ def test_get_active_validator_indices(sample_validator_record_params):
     active_validator_indices = get_active_validator_indices(validators)
     assert len(active_validator_indices) == 3
 
-    # Make one validator becomes PENDING_EXIT.
+    # Make one validator becomes ACTIVE_PENDING_EXIT.
     validators[0] = validators[0].copy(
-        status=ValidatorStatusCode.PENDING_EXIT,
+        status=ValidatorStatusCode.ACTIVE_PENDING_EXIT,
     )
     active_validator_indices = get_active_validator_indices(validators)
     assert len(active_validator_indices) == 3
 
-    # Make one validator becomes PENDING_EXIT.
+    # Make one validator becomes EXITED_WITHOUT_PENALTY.
     validators[0] = validators[0].copy(
         status=ValidatorStatusCode.EXITED_WITHOUT_PENALTY,
     )
@@ -677,7 +677,7 @@ def test_get_new_validator_registry_delta_chain_tip(index,
     [
         (0, 0, 0, 0, 0),
         (0, 0, 0, 1, 0),
-        (0, 0, 20, 10, 0),
+        (0, 1, 20, 10, 0),
         (0, 1, 20, 20, 1),
         (0, 1, 10, 20, 1),
     ]