Skip to content

Commit ab0482e

Browse files
authored
Merge pull request #1135 from veox/run-trinity-integration-tests-with-py3.7
Run trinity integration tests with py3.7
2 parents 4d75541 + 27ebdf8 commit ab0482e

File tree

2 files changed

+46
-16
lines changed

2 files changed

+46
-16
lines changed

.circleci/config.yml

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,14 @@ jobs:
5252
- image: circleci/python:3.6
5353
environment:
5454
TOXENV: lint-py36
55+
5556
py36-docs:
5657
<<: *common
5758
docker:
5859
- image: circleci/python:3.6
5960
environment:
6061
TOXENV: py36-docs
62+
6163
py35-native-state-byzantium:
6264
<<: *common
6365
docker:
@@ -118,6 +120,7 @@ jobs:
118120
- image: circleci/python:3.5
119121
environment:
120122
TOXENV: py35-database
123+
121124
py36-benchmark:
122125
<<: *common
123126
docker:
@@ -244,19 +247,36 @@ jobs:
244247
- image: circleci/python:3.6
245248
environment:
246249
TOXENV: py36-rpc-state-quadratic
250+
247251
py37-core:
248252
<<: *common
249253
docker:
250254
- image: circleci/python:3.7
251255
environment:
252256
TOXENV: py37-core
257+
py37-trinity:
258+
<<: *common
259+
docker:
260+
- image: circleci/python:3.7
261+
environment:
262+
TOXENV: py37-trinity
263+
py37-trinity-integration:
264+
<<: *common
265+
docker:
266+
- image: circleci/python:3.7
267+
environment:
268+
TOXENV: py37-trinity-integration
253269

254270
workflows:
255271
version: 2
256272
test:
257273
jobs:
258-
- py37-core
259274
- py36-docs
275+
276+
- py37-core
277+
- py37-trinity
278+
- py37-trinity-integration
279+
260280
- py36-native-state-byzantium
261281
- py36-native-state-frontier
262282
- py36-native-state-homestead
@@ -278,6 +298,7 @@ workflows:
278298
- py36-p2p
279299
- py36-database
280300
- py36-rpc-state-quadratic
301+
281302
- py35-native-state-byzantium
282303
- py35-native-state-frontier
283304
- py35-native-state-homestead
@@ -288,5 +309,6 @@ workflows:
288309
- py35-core
289310
- py35-transactions
290311
- py35-database
312+
291313
- lint-py35
292314
- lint-py36

tox.ini

Lines changed: 23 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
[tox]
22
envlist=
3-
py37-core
43
py{35,36}-{core,database,transactions,vm,native-blockchain}
54
py{36}-{benchmark,p2p,trinity}
65
py{36}-rpc-blockchain
76
py{36}-rpc-state-{frontier,homestead,eip150,eip158,byzantium,quadratic}
87
py{35,36}-native-state-{frontier,homestead,eip150,eip158,byzantium,constantinople,metropolis}
8+
py37-{core,trinity,trinity-integration}
99
lint-py{35,36}
1010

1111
[flake8]
@@ -53,17 +53,15 @@ basepython =
5353
whitelist_externals=
5454
make
5555
deps = .[doc]
56-
basepython=python3.6
5756
passenv =
5857
PYTEST_ADDOPTS
5958
TRAVIS_EVENT_TYPE
6059
commands=
6160
make validate-docs
6261

6362

64-
[testenv:py36-trinity-integration]
63+
[common-trinity-integration]
6564
deps = .[eth-extras, test]
66-
basepython=python3.6
6765
passenv =
6866
PYTEST_ADDOPTS
6967
TRAVIS_EVENT_TYPE
@@ -72,37 +70,47 @@ commands=
7270
# due to multiple Trinity instances competing for the same ports
7371
py.test -n 1 {posargs:tests/trinity/integration/}
7472

73+
[testenv:py36-trinity-integration]
74+
deps = {[common-trinity-integration]deps}
75+
passenv = {[common-trinity-integration]passenv}
76+
commands = {[common-trinity-integration]commands}
77+
78+
[testenv:py37-trinity-integration]
79+
deps = {[common-trinity-integration]deps}
80+
passenv = {[common-trinity-integration]passenv}
81+
commands = {[common-trinity-integration]commands}
82+
7583

7684
[testenv:py36-benchmark]
7785
deps = .[eth-extras, benchmark]
78-
basepython=python3.6
7986
commands=
8087
benchmark: {toxinidir}/scripts/benchmark/run.py
8188

8289

83-
[testenv:lint-py35]
90+
[common-lint]
8491
deps = .[lint]
85-
basepython=python3.5
8692
setenv=MYPYPATH={toxinidir}:{toxinidir}/stubs
8793
commands=
8894
flake8 {toxinidir}/eth
95+
96+
[testenv:lint-py35]
97+
deps = {[common-lint]deps}
98+
setenv = {[common-lint]setenv}
99+
commands=
100+
{[common-lint]commands}
89101
flake8 {toxinidir}/tests --exclude="trinity,p2p"
90102
# TODO: Drop --ignore-missing-imports once we have type annotations for eth_utils, coincurve and cytoolz
91103
mypy --follow-imports=silent --ignore-missing-imports --no-strict-optional --check-untyped-defs --disallow-incomplete-defs -p eth
92104

93-
94105
[testenv:lint-py36]
95-
deps = .[lint]
96-
basepython=python3.6
97-
setenv=MYPYPATH={toxinidir}:{toxinidir}/stubs
106+
deps = {[common-lint]deps}
107+
setenv = {[common-lint]setenv}
98108
commands=
99-
flake8 {toxinidir}/eth
109+
{[common-lint]commands}
110+
flake8 {toxinidir}/tests
100111
flake8 {toxinidir}/p2p
101112
flake8 {toxinidir}/trinity
102-
flake8 {toxinidir}/tests
103113
flake8 {toxinidir}/scripts
104114
# TODO: Drop --ignore-missing-imports once we have type annotations for eth_utils, coincurve and cytoolz
105115
mypy --follow-imports=silent --ignore-missing-imports --no-strict-optional --check-untyped-defs --disallow-incomplete-defs --disallow-untyped-defs --disallow-any-generics scripts/benchmark
106116
mypy --follow-imports=silent --ignore-missing-imports --no-strict-optional --check-untyped-defs --disallow-incomplete-defs --disallow-untyped-defs --disallow-any-generics -p p2p -p trinity
107-
108-

0 commit comments

Comments
 (0)