Apply suggestions from code review

Co-Authored-By: hwwhww <[email protected]>

Author: djrtwo

eth/beacon/db/chain.py

@@ -305,7 +305,7 @@ def _persist_block_chain(
             )
 
             # TODO: It's a stub before we implement fork choice rule
-            score += block.slot
+            score = block.slot
 
             db.set(
                 SchemaV1.make_block_hash_to_score_lookup_key(block.hash),
@@ -409,15 +409,15 @@ def _add_block_slot_to_hash_lookup(db: BaseDB, block: BaseBeaconBlock) -> None:
         )
 
     #
-    # Active State API
+    # Beacon State API
     #
     def get_state_by_root(self, state_root: Hash32) -> BeaconState:
         return self._get_state_by_root(self.db, state_root)
 
     @staticmethod
     def _get_state_by_root(db: BaseDB, state_root: Hash32) -> BeaconState:
         """
-        Return the requested crystallized state as specified by state hash.
+        Return the requested beacon state as specified by state hash.
 
         Raises StateRootNotFound if it is not present in the db.
         """

eth/beacon/state_machines/configs.py

@@ -15,7 +15,6 @@
         ('MIN_ONLINE_DEPOSIT_SIZE', int),  # ETH
         ('DEPOSIT_CONTRACT_ADDRESS', Address),
         ('TARGET_COMMITTEE_SIZE', int),  # validators
-        ('GENESIS_TIME', int),  # seconds
         ('SLOT_DURATION', int),  # seconds
         ('CYCLE_LENGTH', int),  # slots
         ('MIN_VALIDATOR_SET_CHANGE_INTERVAL', int),  # slots

eth/beacon/state_machines/forks/serenity/configs.py

@@ -10,7 +10,6 @@
     MIN_ONLINE_DEPOSIT_SIZE=2**4,  # = 16 ETH
     DEPOSIT_CONTRACT_ADDRESS=ZERO_ADDRESS,  # TODO: TBD
     TARGET_COMMITTEE_SIZE=2**8,  # = 256 validators
-    GENESIS_TIME=0,  # TBD seconds
     SLOT_DURATION=6,  # seconds
     CYCLE_LENGTH=2**6,  # = 64 slots
     MIN_VALIDATOR_SET_CHANGE_INTERVAL=2**8,  # = 256 slots

eth/beacon/types/proposal_signed_data.py

@@ -15,7 +15,6 @@ class ProposalSignedData(rlp.Serializable):
     """
     fields = [
         # Fork version
-        ('fork_version', uint64),
         # Slot number
         ('slot', uint64),
         # Shard number (or `2**64 - 1` for beacon chain)
@@ -25,12 +24,10 @@ class ProposalSignedData(rlp.Serializable):
     ]
 
     def __init__(self,
-                 fork_version: int,
                  slot: int,
                  shard: int,
                  block_hash: Hash32) -> None:
         super().__init__(
-            fork_version=fork_version,
             slot=slot,
             shard=shard,
             block_hash=block_hash,

eth/beacon/types/special_records.py

@@ -4,7 +4,7 @@
 )
 
 from eth.rlp.sedes import (
-    uint8,
+    uint64,
 )
 
 
@@ -14,7 +14,7 @@ class SpecialRecord(rlp.Serializable):
     """
     fields = [
         # Kind
-        ('kind', uint8),
+        ('kind', uint64),
         # Data
         ('data', binary),
     ]