Replaces set with frozenset (#1602)

* Replaces set with frozenset

* Imports frozenSet from typings

* minor fix

* Adds Set in state

* Adds FrozenSet to PeerSubscriber class

* replaces set with frozenset

* changes in return type

* changes in return type

* changes set to frozen set

* changes set to frozen set

Author: vardan10

p2p/peer.py

@@ -20,7 +20,7 @@
     Iterator,
     List,
     NamedTuple,
-    Set,
+    FrozenSet,
     Tuple,
     Type,
 )
@@ -636,7 +636,7 @@ class PeerSubscriber(ABC):
 
     @property
     @abstractmethod
-    def subscription_msg_types(self) -> Set[Type[protocol.Command]]:
+    def subscription_msg_types(self) -> FrozenSet[Type[protocol.Command]]:
         """
         The `p2p.protocol.Command` types that this class subscribes to.  Any
         command which is not in this set will not be passed to this subscriber.
@@ -731,7 +731,7 @@ def subscribe_peer(self, peer: BasePeer) -> Iterator[None]:
 class MsgBuffer(PeerSubscriber):
     logger = logging.getLogger('p2p.peer.MsgBuffer')
     msg_queue_maxsize = 500
-    subscription_msg_types = {protocol.Command}
+    subscription_msg_types = frozenset({protocol.Command})
 
     @to_tuple
     def get_messages(self) -> Iterator[PeerMessage]:

trinity/plugins/builtin/tx_pool/pool.py

@@ -3,7 +3,7 @@
     Callable,
     Iterable,
     List,
-    Set,
+    FrozenSet,
     Type,
 )
 import uuid
@@ -60,7 +60,7 @@ def __init__(self,
         self._bloom = BloomFilter(max_elements=1000000)
         self._bloom_salt = str(uuid.uuid4())
 
-    subscription_msg_types: Set[Type[Command]] = {Transactions}
+    subscription_msg_types: FrozenSet[Type[Command]] = frozenset({Transactions})
 
     # This is a rather arbitrary value, but when the sync is operating normally we never see
     # the msg queue grow past a few hundred items, so this should be a reasonable limit for

trinity/protocol/bcc/servers.py

@@ -2,7 +2,7 @@
 from typing import (
     cast,
     Iterable,
-    Set,
+    FrozenSet,
     Type,
 )
 
@@ -41,9 +41,9 @@
 
 
 class BCCRequestServer(BaseRequestServer):
-    subscription_msg_types: Set[Type[Command]] = {
+    subscription_msg_types: FrozenSet[Type[Command]] = frozenset({
         GetBeaconBlocks,
-    }
+    })
 
     def __init__(self,
                  db: BaseBeaconChainDB,

trinity/protocol/common/managers.py

@@ -5,7 +5,7 @@
     AsyncGenerator,
     Callable,
     Generic,
-    Set,
+    FrozenSet,
     Tuple,
     Type,
     cast,
@@ -46,8 +46,8 @@ class ResponseCandidateStream(
     # PeerSubscriber
     #
     @property
-    def subscription_msg_types(self) -> Set[Type[Command]]:
-        return {self.response_msg_type}
+    def subscription_msg_types(self) -> FrozenSet[Type[Command]]:
+        return frozenset({self.response_msg_type})
 
     msg_queue_maxsize = 100
 

trinity/protocol/eth/monitors.py

@@ -3,4 +3,4 @@
 
 
 class ETHChainTipMonitor(BaseChainTipMonitor):
-    subscription_msg_types = {commands.NewBlock}
+    subscription_msg_types = frozenset({commands.NewBlock})

trinity/protocol/eth/servers.py

@@ -1,7 +1,7 @@
 from typing import (
     Any,
     Dict,
-    Set,
+    FrozenSet,
     Sequence,
     Type,
     Union,
@@ -124,7 +124,7 @@ class ETHRequestServer(BaseRequestServer):
     Monitor commands from peers, to identify inbound requests that should receive a response.
     Handle those inbound requests by querying our local database and replying.
     """
-    subscription_msg_types: Set[Type[Command]] = {
+    subscription_msg_types: FrozenSet[Type[Command]] = frozenset({
         commands.GetBlockHeaders,
         commands.GetBlockBodies,
         commands.GetReceipts,
@@ -133,7 +133,7 @@ class ETHRequestServer(BaseRequestServer):
         # until the messages are properly handled.
         commands.Transactions,
         commands.NewBlockHashes,
-    }
+    })
 
     def __init__(
             self,

trinity/protocol/les/monitors.py

@@ -3,4 +3,4 @@
 
 
 class LightChainTipMonitor(BaseChainTipMonitor):
-    subscription_msg_types = {commands.Announce}
+    subscription_msg_types = frozenset({commands.Announce})

trinity/protocol/les/servers.py

@@ -1,7 +1,7 @@
 from typing import (
     Any,
     Dict,
-    Set,
+    FrozenSet,
     Type,
     cast,
 )
@@ -44,9 +44,9 @@ class LightRequestServer(BaseRequestServer):
     Monitor commands from peers, to identify inbound requests that should receive a response.
     Handle those inbound requests by querying our local database and replying.
     """
-    subscription_msg_types: Set[Type[Command]] = {
+    subscription_msg_types: FrozenSet[Type[Command]] = frozenset({
         commands.GetBlockHeaders,
-    }
+    })
 
     def __init__(
             self,

trinity/sync/full/chain.py

@@ -13,7 +13,7 @@
     Dict,
     List,
     NamedTuple,
-    Set,
+    FrozenSet,
     Tuple,
     Type,
     cast,
@@ -140,7 +140,7 @@ class BaseBodyChainSyncer(BaseHeaderChainSyncer, PeerSubscriber):
     _pending_bodies: Dict[BlockHeader, BlockBody]
 
     # We are only interested in peers entering or leaving the pool
-    subscription_msg_types: Set[Type[Command]] = set()
+    subscription_msg_types: FrozenSet[Type[Command]] = frozenset()
 
     # This is a rather arbitrary value, but when the sync is operating normally we never see
     # the msg queue grow past a few hundred items, so this should be a reasonable limit for

trinity/sync/full/state.py

@@ -11,6 +11,7 @@
     Iterable,
     List,
     Set,
+    FrozenSet,
     Tuple,
     Type,
 )
@@ -101,7 +102,7 @@ def __init__(self,
         self._peer_missing_nodes: Dict[ETHPeer, Set[Hash32]] = collections.defaultdict(set)
 
     # We are only interested in peers entering or leaving the pool
-    subscription_msg_types: Set[Type[Command]] = set()
+    subscription_msg_types: FrozenSet[Type[Command]] = frozenset()
 
     # This is a rather arbitrary value, but when the sync is operating normally we never see
     # the msg queue grow past a few hundred items, so this should be a reasonable limit for