Skip to content

Commit b8cc463

Browse files
committed
Ignore modified uncle test that seems broken
See the code comment for the github issue.
1 parent b59a8b6 commit b8cc463

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

tests/json-fixtures/test_blockchain.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -181,12 +181,18 @@
181181
('GeneralStateTests/stSStoreTest/InitCollision.json', 'InitCollision_d0g0v0_Istanbul'), # noqa: E501
182182
# Perhaps even stranger, d2 starts failing again after fixing a long-hidden consensus bug
183183
# but not in Constantinople, only in Istanbul.
184-
('GeneralStateTests/stSStoreTest/InitCollision.json', 'InitCollision_d2g0v0_Istanbul'), # noqa: E501
185-
('GeneralStateTests/stSStoreTest/InitCollision.json', 'InitCollision_d1g0v0_Istanbul'), # noqa: E501
184+
('GeneralStateTests/stSStoreTest/InitCollision.json', 'InitCollision_d2g0v0_Istanbul'),
185+
('GeneralStateTests/stSStoreTest/InitCollision.json', 'InitCollision_d1g0v0_Istanbul'),
186186
# The d2 variant started failing again after fixing a long-hidden consensus bug
187187
# but only in Istanbul, not in Constantinople.
188-
('GeneralStateTests/stSStoreTest/InitCollision.json', 'InitCollision_d2g0v0_Istanbul'), # noqa: E501
189-
('GeneralStateTests/stSStoreTest/InitCollision.json', 'InitCollision_d3g0v0_Istanbul'), # noqa: E501
188+
('GeneralStateTests/stSStoreTest/InitCollision.json', 'InitCollision_d2g0v0_Istanbul'),
189+
('GeneralStateTests/stSStoreTest/InitCollision.json', 'InitCollision_d3g0v0_Istanbul'),
190+
# It's not clear how or why this test changed. It doesn't make sense that it only tests Istanbul
191+
# either. See: https://github.com/ethereum/tests/issues/787
192+
# The test seems to claim to test what happens if the uncle timestamp is the same as
193+
# the block, but the RLP doesn't encode a matching timestamp.
194+
('InvalidBlocks/bcUncleHeaderValidity/incorrectUncleTimestamp.json', 'incorrectUncleTimestamp_Istanbul'), # noqa: E501
195+
('InvalidBlocks/bcUncleHeaderValidity/incorrectUncleTimestamp.json', 'incorrectUncleTimestamp_Berlin'), # noqa: E501
190196
}
191197

192198

0 commit comments

Comments
 (0)