Skip to content

Commit e15e3e6

Browse files
committed
Ensure a target number of validators rather than rely on the fixture
1 parent 06ec796 commit e15e3e6

File tree

1 file changed

+23
-7
lines changed

1 file changed

+23
-7
lines changed

tests/beacon/test_helpers.py

Lines changed: 23 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -797,11 +797,9 @@ def _get_indices_and_signatures(num_validators, message, privkeys, fork_data, sl
797797
return (indices, signatures)
798798

799799

800-
def _correct_slashable_vote_data_params(params, validators, messages, privkeys, fork_data):
800+
def _correct_slashable_vote_data_params(num_validators, params, messages, privkeys, fork_data):
801801
valid_params = copy.deepcopy(params)
802802

803-
num_validators = len(validators)
804-
805803
key = "custody_bit_0_indices"
806804
(poc_0_indices, poc_0_signatures) = _get_indices_and_signatures(
807805
num_validators,
@@ -865,7 +863,16 @@ def _create_slashable_vote_data_messages(params):
865863
return votes.messages
866864

867865

868-
def test_verify_slashable_vote_data_signature(privkeys,
866+
@pytest.mark.parametrize(
867+
(
868+
'num_validators',
869+
),
870+
[
871+
(40,),
872+
]
873+
)
874+
def test_verify_slashable_vote_data_signature(num_validators,
875+
privkeys,
869876
sample_beacon_state_params,
870877
genesis_validators,
871878
sample_slashable_vote_data_params,
@@ -888,8 +895,8 @@ def test_verify_slashable_vote_data_signature(privkeys,
888895

889896
fork_data = ForkData(**sample_fork_data_params)
890897
valid_params = _correct_slashable_vote_data_params(
898+
num_validators,
891899
sample_slashable_vote_data_params,
892-
genesis_validators,
893900
messages,
894901
privkeys,
895902
fork_data,
@@ -911,6 +918,14 @@ def _run_verify_slashable_vote(params, state, max_casper_votes, should_succeed):
911918
assert not result
912919

913920

921+
@pytest.mark.parametrize(
922+
(
923+
'num_validators',
924+
),
925+
[
926+
(40,),
927+
]
928+
)
914929
@pytest.mark.parametrize(
915930
(
916931
'param_mapper',
@@ -926,7 +941,8 @@ def _run_verify_slashable_vote(params, state, max_casper_votes, should_succeed):
926941
), False, True),
927942
],
928943
)
929-
def test_verify_slashable_vote_data(param_mapper,
944+
def test_verify_slashable_vote_data(num_validators,
945+
param_mapper,
930946
should_succeed,
931947
needs_fork_data,
932948
privkeys,
@@ -953,8 +969,8 @@ def test_verify_slashable_vote_data(param_mapper,
953969

954970
fork_data = ForkData(**sample_fork_data_params)
955971
params = _correct_slashable_vote_data_params(
972+
num_validators,
956973
sample_slashable_vote_data_params,
957-
genesis_validators,
958974
messages,
959975
privkeys,
960976
fork_data,

0 commit comments

Comments
 (0)