Make tests for validate_proposer_signature parametrized

Author: Bhargavasomu

tests/beacon/state_machines/test_validation.py

@@ -9,25 +9,45 @@
 )
 
 from eth.beacon.types.blocks import BaseBeaconBlock
+from eth.beacon.types.proposal_signed_data import (
+    ProposalSignedData,
+)
 from eth.beacon.types.states import BeaconState
 
+from eth._utils import bls
+
 from tests.beacon.helpers import mock_validator_record
 from tests.beacon.test_helpers import (
     get_sample_shard_committees_at_slots,
 )
 
 
+@pytest.mark.parametrize(
+    'proposer_privkey, proposer_pubkey, is_valid_signature',
+    (
+        (0, bls.privtopub(0), True),
+        (0, bls.privtopub(0) + 1, False),
+        (0, 123, False),
+
+        (123, bls.privtopub(123), True),
+        (123, bls.privtopub(123) + 1, False),
+        (123, 123, False),
+    )
+)
 def test_validate_proposer_signature(
-        beacon_chain_shard_number,
-        epoch_length,
+        proposer_privkey,
+        proposer_pubkey,
+        is_valid_signature,
         sample_beacon_block_params,
         sample_beacon_state_params,
-        sample_shard_committee_params):
-    block = BaseBeaconBlock(**sample_beacon_block_params)
+        sample_shard_committee_params,
+        beacon_chain_shard_number,
+        epoch_length):
+
     state = BeaconState(**sample_beacon_state_params).copy(
         validator_registry=[
             mock_validator_record(
-                pubkey=0,
+                pubkey=proposer_pubkey,
                 max_deposit=0,
             )
             for _ in range(10)
@@ -39,40 +59,35 @@ def test_validate_proposer_signature(
         ),
     )
 
-    validate_proposer_signature(
-        state,
-        block,
-        beacon_chain_shard_number,
-        epoch_length,
-    )
-
+    default_block = BaseBeaconBlock(**sample_beacon_block_params)
+    empty_signature_block_root = BaseBeaconBlock.get_block_without_signature_root(default_block)
 
-def test_validate_proposer_bad_signature(
+    proposal_root = ProposalSignedData(
+        state.slot,
         beacon_chain_shard_number,
-        epoch_length,
-        sample_beacon_block_params,
-        sample_beacon_state_params,
-        sample_shard_committee_params):
-    block = BaseBeaconBlock(**sample_beacon_block_params)
-    state = BeaconState(**sample_beacon_state_params).copy(
-        validator_registry=[
-            mock_validator_record(
-                pubkey=123,
-                max_deposit=0,
-            )
-            for _ in range(10)
-        ],
-        shard_committees_at_slots=get_sample_shard_committees_at_slots(
-            num_slot=128,
-            num_shard_committee_per_slot=10,
-            sample_shard_committee_params=sample_shard_committee_params,
+        empty_signature_block_root,
+    ).root
+
+    proposed_block = BaseBeaconBlock(**sample_beacon_block_params).copy(
+        signature=bls.sign(
+            message=proposal_root,
+            privkey=proposer_privkey,
+            domain=2,
         ),
     )
 
-    with pytest.raises(ValidationError):
+    if is_valid_signature:
         validate_proposer_signature(
             state,
-            block,
+            proposed_block,
             beacon_chain_shard_number,
             epoch_length,
         )
+    else:
+        with pytest.raises(ValidationError):
+            validate_proposer_signature(
+                state,
+                proposed_block,
+                beacon_chain_shard_number,
+                epoch_length,
+            )