remove is_validating_signatures from attestation validation

Author: djrtwo

eth/beacon/state_machines/forks/serenity/operations.py

@@ -10,8 +10,7 @@
 
 def process_attestations(state: BeaconState,
                          block: BaseBeaconBlock,
-                         config: BeaconConfig,
-                         is_validating_signatures: bool=True) -> BeaconState:
+                         config: BeaconConfig) -> BeaconState:
     """
     Implements 'per-block-processing.operations.attestations' portion of Phase 0 spec:
     https://github.com/ethereum/eth2.0-specs/blob/master/specs/core/0_beacon-chain.md#attestations-1
@@ -27,7 +26,6 @@ def process_attestations(state: BeaconState,
             attestation,
             config.EPOCH_LENGTH,
             config.MIN_ATTESTATION_INCLUSION_DELAY,
-            is_validating_signatures,
         )
 
     # update_latest_attestations

eth/beacon/state_machines/forks/serenity/validation.py

@@ -37,8 +37,7 @@
 def validate_serenity_attestation(state: Type[BeaconState],
                                   attestation: Attestation,
                                   epoch_length: int,
-                                  min_attestation_inclusion_delay: int,
-                                  is_validating_signatures: bool=True) -> None:
+                                  min_attestation_inclusion_delay: int) -> None:
     """
     Validate the given ``attestation``.
     Raise ``ValidationError`` if it's invalid.
@@ -75,12 +74,11 @@ def validate_serenity_attestation(state: Type[BeaconState],
 
     validate_serenity_attestation_shard_block_root(attestation.data)
 
-    if is_validating_signatures:
-        validate_serenity_attestation_aggregate_signature(
-            state,
-            attestation,
-            epoch_length,
-        )
+    validate_serenity_attestation_aggregate_signature(
+        state,
+        attestation,
+        epoch_length,
+    )
 
 
 def validate_serenity_attestation_slot(attestation_data: AttestationData,