slogging is_active is not a propery

Author: heikoheiko

ethereum/processblock.py

@@ -209,12 +209,13 @@ def apply_msg(ext, msg):
 
 
 def _apply_msg(ext, msg, code):
-    if log_msg.is_active:
+    if log_msg.is_active('trace'):
         log_msg.debug("MSG APPLY", sender=encode_hex(msg.sender), to=encode_hex(msg.to),
                       gas=msg.gas, value=msg.value,
                       data=encode_hex(msg.data.extract_all()))
-    if log_state.is_active:
-        log_state.trace('MSG PRE STATE', account=msg.to, bal=ext.get_balance(msg.to), state=ext.log_storage(msg.to))
+    if log_state.is_active('trace'):
+        log_state.trace('MSG PRE STATE', account=msg.to, bal=ext.get_balance(
+            msg.to), state=ext.log_storage(msg.to))
     # Transfer value, instaquit if not enough
     snapshot = ext._block.snapshot()
     o = ext._block.transfer_value(msg.sender, msg.to, msg.value)
@@ -229,11 +230,12 @@ def _apply_msg(ext, msg, code):
         res, gas, dat = vm.vm_execute(ext, msg, code)
     gas = int(gas)
     assert utils.is_numeric(gas)
-    if log_msg.is_active:
+    if log_msg.is_active('trace'):
         log_msg.debug('MSG APPLIED', result=o, gas_remained=gas,
                       sender=msg.sender, to=msg.to, data=dat)
-    if log_state.is_active:
-        log_state.trace('MSG POST STATE', account=msg.to, bal=ext.get_balance(msg.to), state=ext.log_storage(msg.to))
+    if log_state.is_active('trace'):
+        log_state.trace('MSG POST STATE', account=msg.to, bal=ext.get_balance(
+            msg.to), state=ext.log_storage(msg.to))
 
     if res == 0:
         log_msg.debug('REVERTING')

ethereum/tests/test_logging.py

@@ -70,6 +70,13 @@ def test_baseconfig():
     th = setup_logging(config_string=config_string)
 
 
+def test_is_active2():
+    setup_logging(':info')
+    tester = slogging.get_logger('tester')
+    assert tester.is_active(level_name='info')
+    assert not tester.is_active(level_name='trace')
+
+
 def test_lvl_trace():
     config_string = ':trace'
     th = setup_logging(config_string=config_string)
@@ -317,3 +324,12 @@ def run_vm(raise_error=False):
 def test_cleanup():
     config_string = ':debug'
     slogging.configure(config_string=config_string)
+
+
+if __name__ == '__main__':
+    slogging.configure(':debug')
+    tester = slogging.get_logger('tester')
+    assert tester.is_active(level_name='info')
+    slogging.set_level('tester', 'trace')
+    assert tester.is_active(level_name='trace')
+    tester.info('done')