use floored division

Author: pipermerriam

ethereum/abi.py

@@ -494,12 +494,12 @@ def decode_single(typ, data):
         return (o - 2**int(sub)) if o >= 2**(int(sub) - 1) else o
     elif base == 'ureal':
         high, low = [int(x) for x in sub.split('x')]
-        return big_endian_to_int(data) * 1.0 / 2**low
+        return big_endian_to_int(data) * 1.0 // 2**low
     elif base == 'real':
         high, low = [int(x) for x in sub.split('x')]
         o = big_endian_to_int(data)
         i = (o - 2**(high+low)) if o >= 2**(high+low-1) else o
-        return (i * 1.0 / 2**low)
+        return (i * 1.0 // 2**low)
     elif base == 'bool':
         return bool(int(encode_hex(data), 16))
 

ethereum/blocks.py

@@ -1169,10 +1169,13 @@ def finalize(self):
         self.ether_delta += delta
 
         for uncle in self.uncles:
-            r = self.config['BLOCK_REWARD'] * \
-                (self.config['UNCLE_DEPTH_PENALTY_FACTOR'] + uncle.number - self.number) \
-                / self.config['UNCLE_DEPTH_PENALTY_FACTOR']
-            r = int(r)
+            br = self.config['BLOCK_REWARD']
+            udpf = self.config['UNCLE_DEPTH_PENALTY_FACTOR']
+            un = uncle.number
+            bn = self.number
+
+            r = int(br * (udpf + un - bn) // udpf)
+
             self.delta_balance(uncle.coinbase, r)
             self.ether_delta += r
         self.commit_state()
@@ -1307,7 +1310,7 @@ def calc_gaslimit(parent):
 
 def check_gaslimit(parent, gas_limit):
     config = parent.config
-    #  block.gasLimit - parent.gasLimit <= parent.gasLimit / GasLimitBoundDivisor
+    #  block.gasLimit - parent.gasLimit <= parent.gasLimit // GasLimitBoundDivisor
     gl = parent.gas_limit // config['GASLIMIT_ADJMAX_FACTOR']
     a = bool(abs(gas_limit - parent.gas_limit) <= gl)
     b = bool(gas_limit >= config['MIN_GAS_LIMIT'])

ethereum/ethash_utils.py

@@ -94,7 +94,7 @@ def deserialize_cache(ds):
 class ListWrapper(list):
     def __init__(self, data):
         self.data = data
-        self.len = len(data) / HASH_BYTES
+        self.len = len(data) // HASH_BYTES
 
     def __len__(self):
         return self.len
@@ -122,14 +122,14 @@ def isprime(x):
 def get_cache_size(block_number):
     sz = CACHE_BYTES_INIT + CACHE_BYTES_GROWTH * (block_number // EPOCH_LENGTH)
     sz -= HASH_BYTES
-    while not isprime(sz / HASH_BYTES):
+    while not isprime(sz // HASH_BYTES):
         sz -= 2 * HASH_BYTES
     return sz
 
 
 def get_full_size(block_number):
     sz = DATASET_BYTES_INIT + DATASET_BYTES_GROWTH * (block_number // EPOCH_LENGTH)
     sz -= MIX_BYTES
-    while not isprime(sz / MIX_BYTES):
+    while not isprime(sz // MIX_BYTES):
         sz -= 2 * MIX_BYTES
     return sz

ethereum/ethpow.py

@@ -71,7 +71,7 @@ def check_pow(block_number, header_hash, mixhash, nonce, difficulty):
     mining_output = hashimoto_light(block_number, cache, header_hash, nonce)
     if mining_output[b'mix digest'] != mixhash:
         return False
-    return utils.big_endian_to_int(mining_output[b'result']) <= 2**256 / (difficulty or 1)
+    return utils.big_endian_to_int(mining_output[b'result']) <= 2**256 // (difficulty or 1)
 
 
 class Miner():

ethereum/keys.py

@@ -247,7 +247,7 @@ def big_endian_to_int(value):
 if sys.version_info.major == 3:
 
     def int_to_big_endian(value):
-        byte_length = ceil(value.bit_length() / 8)
+        byte_length = ceil(value.bit_length() // 8)
         return (value).to_bytes(byte_length, byteorder='big')
 
     def big_endian_to_int(value):

ethereum/tests/bintrie.py

@@ -282,8 +282,8 @@ def test(n, m=100):
     o = {
         'total_db_size': sum([len(val) for key, val in l1.kv.items()]),
         'avg_proof_size': sum([len(val) for key, val in l1.kv.items()]),
-        'avg_compressed_proof_size': (p / min(n, m)),
-        'avg_branch_size': (q / min(n, m)),
+        'avg_compressed_proof_size': (p // min(n, m)),
+        'avg_branch_size': (q // min(n, m)),
         'compressed_db_size': len(compress_db(l1))
     }
     return o

ethereum/tests/test_chain.py

@@ -525,7 +525,7 @@ def test_reward_uncles(db):
     assert blk2 == chain.head
     assert chain.head.get_balance(local_coinbase) == \
         2 * chain.env.config['BLOCK_REWARD'] + chain.env.config['NEPHEW_REWARD']
-    assert chain.head.get_balance(uncle_coinbase) == chain.env.config['BLOCK_REWARD'] * 7 / 8
+    assert chain.head.get_balance(uncle_coinbase) == chain.env.config['BLOCK_REWARD'] * 7 // 8
 
 
 # TODO ##########################################

ethereum/tests/test_logging.py

@@ -71,7 +71,7 @@ def test_tracebacks(caplog):
 
     def div(a, b):
         try:
-            _ = a / b
+            _ = a // b
             log.error('heres the stack', stack_info=True)
         except Exception as e:
             log.error('an Exception trace should preceed this msg', exc_info=True)

ethereum/transactions.py

@@ -195,7 +195,7 @@ def __structlog__(self):
     # The >= operator is replaced by > because the integer division N/2 always produces the value
     # which is by 0.5 less than the real N/2
     def check_low_s(self):
-        if self.s > N / 2 or self.s == 0:
+        if self.s > N // 2 or self.s == 0:
             raise InvalidTransaction("Invalid signature S value!")