python3 compatable byte string construction

Author: pipermerriam

ethereum/transactions.py

@@ -87,7 +87,7 @@ def sender(self):
                     pk.public_key = pk.ecdsa_recover(
                         rawhash,
                         pk.ecdsa_recoverable_deserialize(
-                            zpad("".join(chr(c) for c in int_to_32bytearray(self.r)), 32) + zpad("".join(chr(c) for c in int_to_32bytearray(self.s)), 32),
+                            zpad(utils.bytearray_to_bytestr(int_to_32bytearray(self.r)), 32) + zpad(utils.bytearray_to_bytestr(int_to_32bytearray(self.s)), 32),
                             self.v - 27
                         ),
                         raw=True
@@ -126,8 +126,8 @@ def sign(self, key):
         signature = pk.ecdsa_recoverable_serialize(
             pk.ecdsa_sign_recoverable(rawhash, raw=True)
         )
-        signature = signature[0] + chr(signature[1]).encode('utf8')
-        self.v = signature[64] + 27
+        signature = signature[0] + utils.bytearray_to_bytestr([signature[1]])
+        self.v = utils.safe_ord(signature[64]) + 27
         self.r = big_endian_to_int(signature[0:32])
         self.s = big_endian_to_int(signature[32:64])
 

ethereum/utils.py

@@ -35,6 +35,9 @@ def to_string_for_regexp(value):
         return str(value)
     unicode = unicode
 
+    def bytearray_to_bytestr(value):
+        return bytes(''.join(chr(c) for c in value))
+
 else:
     is_numeric = lambda x: isinstance(x, int)
     is_string = lambda x: isinstance(x, bytes)
@@ -56,6 +59,9 @@ def to_string_for_regexp(value):
         return str(to_string(value), 'utf-8')
     unicode = str
 
+    def bytearray_to_bytestr(value):
+        return bytes(value)
+
 isnumeric = is_numeric