Merge branch 'develop' into dep-pycryptodome

Author: joeykrug

.travis.yml

@@ -23,7 +23,7 @@ before_install:
   - if [ -n "$SOLC_VERSION" ]; then sudo apt-get install -y tree unzip; fi
 install:
   - if [ -n "$SOLC_VERSION" ]; then /.$TRAVIS_BUILD_DIR/.travis/install_solc.sh; fi
-  - travis_retry pip install setuptools --upgrade
+  - travis_retry pip install pip setuptools --upgrade
   - travis_retry pip install tox
   - travis_retry pip install coverage
   - travis_retry pip install flake8

README.md

@@ -160,7 +160,7 @@ Contains the Transaction class, with the following methods and values:
 
 ### ethereum.tools.keys
 
-Creates encrypted private key storaes
+Creates encrypted private key storages
 
 * `decode_keystore_json(jsondata, password)` - returns the private key from an encrypted keystore object. NOTE: if you are loading from a file, the most convenient way to do this is `import json; key = decode_keystore_json(json.load(open('filename.json')), 'password')`
 * `make_keystore_json(key, pw, kdf='pbkdf2', cipher='aes-128-ctr')` - creates an encrypted keystore object for the key. Keeping `kdf` and `cipher` at their default values is recommended.

ethereum/tools/tester.py

@@ -157,7 +157,7 @@ def __init__(self, alloc=base_alloc, env=None, genesis=None):
 
     def direct_tx(self, transaction):
         self.last_tx = transaction
-        if privtoaddr(self.last_sender) != transaction.sender:
+        if self.last_sender is not None and privtoaddr(self.last_sender) != transaction.sender:
             self.last_sender = None
         success, output = apply_transaction(self.head_state, transaction)
         self.block.transactions.append(transaction)

ethereum/utils.py

@@ -13,11 +13,11 @@
 
 
 try:
-    import secp256k1
+    import coincurve
 except ImportError:
     import warnings
-    warnings.warn('could not import secp256k1', ImportWarning)
-    secp256k1 = None
+    warnings.warn('could not import coincurve', ImportWarning)
+    coincurve = None
 
 big_endian_to_int = lambda x: big_endian_int.deserialize(str_to_bytes(x).lstrip(b'\x00'))
 int_to_big_endian = lambda x: big_endian_int.serialize(x)
@@ -85,22 +85,15 @@ def bytes_to_int(value):
 
 
 def ecrecover_to_pub(rawhash, v, r, s):
-    if secp256k1 and hasattr(secp256k1, "PublicKey"):
-        # Legendre symbol check; the secp256k1 library does not seem to do this
-        pk = secp256k1.PublicKey(flags=secp256k1.ALL_FLAGS)
-        xc = r * r * r + 7
-        assert pow(xc, (SECP256K1P - 1) // 2, SECP256K1P) == 1
+    if coincurve and hasattr(coincurve, "PublicKey"):
         try:
-            pk.public_key = pk.ecdsa_recover(
+            pk = coincurve.PublicKey.from_signature_and_message(
+                zpad(utils.bytearray_to_bytestr(int_to_32bytearray(r)), 32) + zpad(utils.bytearray_to_bytestr(int_to_32bytearray(s)), 32) +
+                utils.ascii_chr(v - 27),
                 rawhash,
-                pk.ecdsa_recoverable_deserialize(
-                    zpad(bytearray_to_bytestr(int_to_32bytearray(r)), 32) +
-                    zpad(bytearray_to_bytestr(int_to_32bytearray(s)), 32),
-                    v - 27
-                ),
-                raw=True
+                hasher=None,
             )
-            pub = pk.serialize(compressed=False)[1:]
+            pub = pk.format(compressed=False)[1:]
         except:
             pub = b"\x00" * 64
     else:
@@ -111,12 +104,9 @@ def ecrecover_to_pub(rawhash, v, r, s):
 
 
 def ecsign(rawhash, key):
-    if secp256k1 and hasattr(secp256k1, 'PrivateKey'):
-        pk = secp256k1.PrivateKey(key, raw=True)
-        signature = pk.ecdsa_recoverable_serialize(
-            pk.ecdsa_sign_recoverable(rawhash, raw=True)
-        )
-        signature = signature[0] + bytearray_to_bytestr([signature[1]])
+    if coincurve and hasattr(coincurve, 'PrivateKey'):
+        pk = coincurve.PrivateKey(priv)
+        signature = pk.sign_recoverable(msghash, hasher=None)
         v = safe_ord(signature[64]) + 27
         r = big_endian_to_int(signature[0:32])
         s = big_endian_to_int(signature[32:64])

requirements.txt

@@ -7,3 +7,4 @@ py_ecc
 rlp>=0.4.7
 https://github.com/ethereum/ethash/tarball/master
 pycryptodome==3.4.6
+coincurve>=5.0.1