Skip to content

Commit 09f8261

Browse files
authored
Merge pull request #238 from ekpyron/addressMembers
Cast contracts to address before accessing address members.
2 parents 1bd7e1d + 71e9bc8 commit 09f8261

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

test/DAO/DAO.sol

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,7 @@ contract DAO is DAOInterface, Token, TokenCreation {
653653
if (address(p.splitData[0].newDAO) == 0x0000000000000000000000000000000000000000)
654654
revert();
655655
// should never happen
656-
if (this.balance < sumOfProposalDeposits)
656+
if (address(this).balance < sumOfProposalDeposits)
657657
revert();
658658
p.splitData[0].splitBalance = actualBalance();
659659
p.splitData[0].rewardToken = rewardToken[address(this)];
@@ -722,7 +722,7 @@ contract DAO is DAOInterface, Token, TokenCreation {
722722
(rewardToken[msg.sender] * DAOrewardAccount.accumulatedInput()) /
723723
totalRewardToken - DAOpaidOut[msg.sender];
724724

725-
reward = DAOrewardAccount.balance < reward ? DAOrewardAccount.balance : reward;
725+
reward = address(DAOrewardAccount).balance < reward ? address(DAOrewardAccount).balance : reward;
726726

727727
if(_toMembers) {
728728
if (!DAOrewardAccount.payOut(dao.rewardAccount(), reward))
@@ -748,7 +748,7 @@ contract DAO is DAOInterface, Token, TokenCreation {
748748
uint reward =
749749
(balanceOf(_account) * rewardAccount.accumulatedInput()) / totalSupply - paidOut[_account];
750750

751-
reward = rewardAccount.balance < reward ? rewardAccount.balance : reward;
751+
reward = address(rewardAccount).balance < reward ? address(rewardAccount).balance : reward;
752752

753753
if (!rewardAccount.payOut(_account, reward))
754754
revert();
@@ -852,7 +852,7 @@ contract DAO is DAOInterface, Token, TokenCreation {
852852
}
853853

854854
function actualBalance() public view returns (uint _actualBalance) {
855-
return this.balance - sumOfProposalDeposits;
855+
return address(this).balance - sumOfProposalDeposits;
856856
}
857857

858858

test/DAO/TokenCreation.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ contract TokenCreation is TokenCreationInterface, Token {
105105
&& (privateCreation == 0x0000000000000000000000000000000000000000 || privateCreation == msg.sender)) {
106106

107107
uint token = (msg.value * 20) / divisor();
108-
extraBalance.call.value(msg.value - token)("");
108+
address(extraBalance).call.value(msg.value - token)("");
109109
balances[_tokenHolder] += token;
110110
totalSupply += token;
111111
weiGiven[_tokenHolder] += msg.value;
@@ -122,7 +122,7 @@ contract TokenCreation is TokenCreationInterface, Token {
122122
function refund() noEther public {
123123
if (now > closingTime && !isFueled) {
124124
// Get extraBalance - will only succeed when called for the first time
125-
if (extraBalance.balance >= extraBalance.accumulatedInput())
125+
if (address(extraBalance).balance >= extraBalance.accumulatedInput())
126126
extraBalance.payOut(address(this), extraBalance.accumulatedInput());
127127

128128
// Execute refund

0 commit comments

Comments
 (0)