Do not add payable to events in ABI translator (#145)

Author: axic

abi.js

@@ -18,8 +18,8 @@ function update (compilerVersion, abi) {
       hasFallback = true;
     }
 
-    // add 'payable' to everything
-    if (semver.lt(compilerVersion, '0.4.0')) {
+    // add 'payable' to everything except events
+    if (item.type !== 'event' && semver.lt(compilerVersion, '0.4.0')) {
       item.payable = true;
     }
   }

test/abi.js

@@ -10,6 +10,21 @@ tape('ABI translator', function (t) {
     st.deepEqual(abi.update('0.1.1', []), [ { inputs: [], payable: true, type: 'constructor' }, { payable: true, type: 'fallback' } ]);
     st.end();
   });
+  t.test('0.3.6 (constructor)', function (st) {
+    var input = [ { inputs: [], type: 'constructor' } ];
+    st.deepEqual(abi.update('0.3.6', input), [ { inputs: [], payable: true, type: 'constructor' }, { payable: true, type: 'fallback' } ]);
+    st.end();
+  });
+  t.test('0.3.6 (function)', function (st) {
+    var input = [ { inputs: [], type: 'function' } ];
+    st.deepEqual(abi.update('0.3.6', input), [ { inputs: [], payable: true, type: 'function' }, { payable: true, type: 'fallback' } ]);
+    st.end();
+  });
+  t.test('0.3.6 (event)', function (st) {
+    var input = [ { inputs: [], type: 'event' } ];
+    st.deepEqual(abi.update('0.3.6', input), [ { inputs: [], type: 'event' }, { payable: true, type: 'fallback' } ]);
+    st.end();
+  });
   t.test('0.4.0 (has fallback)', function (st) {
     var input = [ { inputs: [], type: 'constructor' } ];
     st.deepEqual(abi.update('0.4.0', input), [ { inputs: [], payable: true, type: 'constructor' } ]);

test/index.js

@@ -1,4 +1,4 @@
 require('./package.js');
+require('./abi.js');
 require('./cli.js');
 require('./determinism.js');
-require('./abi.js');